[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YeFZrEAaPw1Y5wwd@kernel.org>
Date: Fri, 14 Jan 2022 13:08:28 +0200
From: Mike Rapoport <rppt@...nel.org>
To: Wei Yang <richard.weiyang@...il.com>
Cc: hannes@...xchg.org, mhocko@...nel.org, vdavydov.dev@...il.com,
akpm@...ux-foundation.org, shakeelb@...gle.com, guro@...com,
vbabka@...e.cz, willy@...radead.org, songmuchun@...edance.com,
shy828301@...il.com, surenb@...gle.com,
linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
linux-mm@...ck.org
Subject: Re: [PATCH 2/4] mm/memcg: mem_cgroup_per_node is already set to 0 on
allocation
On Tue, Jan 11, 2022 at 01:03:00AM +0000, Wei Yang wrote:
> kzalloc_node() would set data to 0, so it's not necessary to set it
> again.
>
> Signed-off-by: Wei Yang <richard.weiyang@...il.com>
Reviewed-by: Mike Rapoport <rppt@...ux.ibm.com>
> ---
> mm/memcontrol.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 11715f7323c0..a504616f904a 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -5067,8 +5067,6 @@ static int alloc_mem_cgroup_per_node_info(struct mem_cgroup *memcg, int node)
> }
>
> lruvec_init(&pn->lruvec);
> - pn->usage_in_excess = 0;
> - pn->on_tree = false;
> pn->memcg = memcg;
>
> memcg->nodeinfo[node] = pn;
> --
> 2.33.1
>
>
--
Sincerely yours,
Mike.
Powered by blists - more mailing lists