[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <811109b0-ada6-83b4-6d6d-b26b156d279d@igalia.com>
Date: Fri, 14 Jan 2022 09:32:58 -0300
From: "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To: Petr Mladek <pmladek@...e.com>
Cc: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
kernel@...ccoli.net, senozhatsky@...omium.org, rostedt@...dmis.org,
john.ogness@...utronix.de, feng.tang@...el.com,
kexec@...ts.infradead.org, dyoung@...hat.com,
keescook@...omium.org, anton@...msg.org, ccross@...roid.com,
tony.luck@...el.com
Subject: Re: [PATCH V2] panic: Move panic_print before kmsg dumpers
On 14/01/2022 09:26, Petr Mladek wrote:
> [...]
> I see. OK, it makes sense to call it after the panic notifiers when
> they are used. It would be nice to mention the above in the commit
> message and explain why the 2nd call is there.
>
> Just an idea. It might be better to move the 1st call below
> if (!_crash_kexec_post_notifiers). It would make it more
> clear that it is intended for this code path. I mean:
>
> if (!_crash_kexec_post_notifiers) {
> /* ... */
> if (kexec_crash_loaded())
> panic_print_sys_info(false);
>
> __crash_kexec(NULL);
> ...
>
> Best Regards,
> Petr
Perfect Petr, thanks again for the very good ideas! I'll work on V3 and
submit today.
Cheers,
Guilherme
Powered by blists - more mailing lists