linux-kernel - Re: [PATCH 3/3] clk: mediatek: support COMMON_CLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220114021131.1F7C9C36AEA@smtp.kernel.org>
Date:   Thu, 13 Jan 2022 18:11:29 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Matthias Brugger <matthias.bgg@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        Miles Chen <miles.chen@...iatek.com>
Cc:     Miles Chen <miles.chen@...iatek.com>,
        Chun-Jie Chen <chun-jie.chen@...iatek.com>,
        Chen-Yu Tsai <wenst@...omium.org>, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 3/3] clk: mediatek: support COMMON_CLK_MT8192 module build

Quoting Miles Chen (2022-01-10 09:09:59)
> To support COMMON_CLK_MT8192* module build,
> add MODULE_LICENSE and include module.h.
> 
> Cc: Chun-Jie Chen <chun-jie.chen@...iatek.com>
> Cc: Chen-Yu Tsai <wenst@...omium.org>
> Signed-off-by: Miles Chen <miles.chen@...iatek.com>

Have you tried removing the modules? And then reloading them? I also see
that mtk_clk_simple_probe() doesn't actually unregister anything, it
just frees some allocations. Please fix this before making these
modules.