linux-kernel - Re: [PATCH] perf util: Fix use after free in metric_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YeGMoG2pv2+7nQFj@kernel.org>
Date:   Fri, 14 Jan 2022 11:45:52 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     José Expósito <jose.exposito89@...il.com>,
        Ian Rogers <irogers@...gle.com>
Cc:     peterz@...radead.org, mingo@...hat.com, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, jolsa@...hat.com,
        namhyung@...nel.org, ak@...ux.intel.com, john.garry@...wei.com,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf util: Fix use after free in metric__new

Em Wed, Dec 08, 2021 at 06:11:13PM +0100, José Expósito escreveu:
> Addresses-Coverity-ID: 1494000
> Signed-off-by: José Expósito <jose.exposito89@...il.com>

Sorry, overlooked this one, now processing.

You forgot to add:

Fixes: b85a4d61d3022608 ("perf metric: Allow modifiers on metrics")

Ian, I'm taking this one, obvious fix.

- Arnaldo

> ---
>  tools/perf/util/metricgroup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/metricgroup.c b/tools/perf/util/metricgroup.c
> index fffe02aae3ed..4d2fed3aefd1 100644
> --- a/tools/perf/util/metricgroup.c
> +++ b/tools/perf/util/metricgroup.c
> @@ -209,8 +209,8 @@ static struct metric *metric__new(const struct pmu_event *pe,
>  	m->metric_name = pe->metric_name;
>  	m->modifier = modifier ? strdup(modifier) : NULL;
>  	if (modifier && !m->modifier) {
> -		free(m);
>  		expr__ctx_free(m->pctx);
> +		free(m);
>  		return NULL;
>  	}
>  	m->metric_expr = pe->metric_expr;
> -- 
> 2.25.1

-- 

- Arnaldo