linux-kernel - Re: [PATCH v2 0/5] of: base: small cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YeGNuwyenYcr3X2O@robh.at.kernel.org>
Date:   Fri, 14 Jan 2022 08:50:35 -0600
From:   Rob Herring <robh@...nel.org>
To:     Michael Walle <michael@...le.cc>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Frank Rowand <frowand.list@...il.com>
Subject: Re: [PATCH v2 0/5] of: base: small cleanups

On Fri, Jan 14, 2022 at 01:07:18PM +0100, Michael Walle wrote:
> This series is a result of the discussion in [1]. Rob suggested to convert
> the index parameter to unsigned int and drop the check for negative values
> and make them static inline.
> 
> It will also introduce a new variant of the function, although it is unused
> for now. They will be needed when nvmem phandles are modified to take
> additional arguments and need to retain backwards compatibility with older
> device trees.
> 
> Finally, define of_property_read_u{8,16,32,64}_array() unconditionally,
> these are the last ones, which were defined static inline and had an empty
> stub if CONFIG_OF wasn't set.
> 
> [1] https://lore.kernel.org/linux-devicetree/20211228142549.1275412-1-michael@walle.cc/
> 
> Michael Walle (5):
>   of: base: convert index to unsigned for of_parse_phandle()
>   of: base: make small of_parse_phandle() variants static inline
>   of: base: add of_parse_phandle_with_optional_args()
>   of: property: define of_property_read_u{8,16,32,64}_array()
>     unconditionally
>   of: property: use unsigned index for of_link_property()
> 
>  drivers/of/base.c     | 137 +------------
>  drivers/of/property.c |  27 ++-
>  include/linux/of.h    | 446 +++++++++++++++++++++++++-----------------
>  3 files changed, 294 insertions(+), 316 deletions(-)

I've applied the series and plan to send for v5.17-rc1.

Rob