[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD=FV=V+-fdM6M586HhnHiK9Ls-t4GxxmsbCPU0gX85bZeRG_Q@mail.gmail.com>
Date: Fri, 14 Jan 2022 07:02:13 -0800
From: Doug Anderson <dianders@...omium.org>
To: Stephen Boyd <swboyd@...omium.org>
Cc: Bjorn Andersson <bjorn.andersson@...aro.org>,
quic_rjendra@...cinc.com, Sibi Sankar <sibis@...eaurora.org>,
kgodara1@...eaurora.org, Matthias Kaehlcke <mka@...omium.org>,
Prasad Malisetty <pmaliset@...eaurora.org>,
Akhil P Oommen <quic_akhilpo@...cinc.com>,
Andy Gross <agross@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] arm64: dts: qcom: sc7280: Fix gmu unit address
Hi,
On Thu, Jan 13, 2022 at 10:08 PM Stephen Boyd <swboyd@...omium.org> wrote:
>
> Quoting Douglas Anderson (2022-01-13 16:43:00)
> > When processing sc7280 device trees, I can see:
> >
> > Warning (simple_bus_reg): /soc@...mu@...9000:
> > simple-bus unit address format error, expected "3d6a000"
> >
> > There's a clear typo in the node name. Fix it.
> >
> > Fixes: 96c471970b7b ("arm64: dts: qcom: sc7280: Add gpu support")
> > Signed-off-by: Douglas Anderson <dianders@...omium.org>
> > ---
>
> Reviewed-by: Stephen Boyd <swboyd@...omium.org>
Thanks for all the reviews!
> BTW, gmu isn't a "standard" node name so might be worth replacing that
> with something else but I have no idea what. Maybe "firmware" or
> "power-controller"?
"gmu" matches what's in the "example" in
Documentation/devicetree/bindings/display/msm/gmu.yaml. That was
blessed by Rob Herring. If you think it should be something different,
perhaps post a patch changing the example in the bindings?
-Doug
Powered by blists - more mailing lists