linux-kernel - Re: [PATCH 3/3] dt-bindings: trivial-devices: fix comment indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YeGVEMl5aKgIHZIv@robh.at.kernel.org>
Date:   Fri, 14 Jan 2022 09:21:52 -0600
From:   Rob Herring <robh@...nel.org>
To:     Stanislav Jakubek <stano.jakubek@...il.com>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] dt-bindings: trivial-devices: fix comment indentation

On Thu, Jan 13, 2022 at 02:39:40PM +0100, Stanislav Jakubek wrote:
> Indent comments the same as the content they describe.
> Fixes yamllint warnings like:
> 32:13     warning  comment not indented like content  (comments-indentation)

But that's not a warning we enable or is this something new in newer 
yamllint?

In any case, a change like this can only be done at the end of the merge 
window just before rc1. Otherwise, it is merge conflict hell. I would do 
that, but I really prefer it the way it is. The reason is it makes the 
'-' stand out more and those are easy to miss in yaml. For example, 
these look the same but are a bit different:

- items:
  - const: foo

- items:
    const: foo

> 
> Signed-off-by: Stanislav Jakubek <stano.jakubek@...il.com>
> ---
>  .../devicetree/bindings/trivial-devices.yaml  | 314 +++++++++---------
>  1 file changed, 157 insertions(+), 157 deletions(-)