linux-kernel - Re: [RESEND] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 14 Jan 2022 17:29:52 +0200
From:   Abel Vesa <abel.vesa@....com>
To:     Rob Herring <robh@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mark Rutland <mark.rutland@....com>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        devicetree@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible

On 21-12-21 09:43:39, Rob Herring wrote:
> On Tue, Dec 21, 2021 at 7:16 AM Abel Vesa <abel.vesa@....com> wrote:
> >
> > Add i.MX8DXL lpuart compatible to the bindings documentation.
> >
> > Signed-off-by: Abel Vesa <abel.vesa@....com>
> > ---
> >
> > This is a resend of the following, but as a separate patch.
> >
> > https://lore.kernel.org/linux-arm-kernel/YcCisM3BqM984k%2F1@kroah.com/
> >
> >  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > index 6e04e3848261..1f482e166467 100644
> > --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > @@ -30,6 +30,10 @@ properties:
> >        - items:
> >            - const: fsl,imx8qm-lpuart
> >            - const: fsl,imx8qxp-lpuart
> > +      - items:
> > +          - const: fsl,imx8dxl-lpuart
> > +          - const: fsl,imx8qxp-lpuart
> > +          - const: fsl,imx7ulp-lpuart
> 
> It doesn't really make sense that imx8qm and imx8dxl are backwards
> compatible with imx8qxp, but only imx8qm is backwards compatible to
> imx7ulp. Ir only makes sense if some feature/quirk specific to
> fsl,imx7ulp-lpuart is gone in imx8qm.
> 

Actually, I'll just drop the imx7ulp from the imx8dxl dts nodes and then
from this patch.

The imx7ulp compatible is not needed anymore because the following
commit:

b4b844930f27bf7019 ("tty: serial: fsl_lpuart: drop earlycon entry for i.MX8QXP"

got reverted by:

4e9679738a918d8a48 ('Revert "tty: serial: fsl_lpuart: drop earlycon entry for i.MX8QXP"')

Will resend with proper changes.

> Rob