linux-kernel - Re: [PATCH 4/5] ALSA: hda: cs35l41: Tidyup code and add default cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hfspq47ks.wl-tiwai@suse.de>
Date:   Fri, 14 Jan 2022 17:15:31 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Lucas Tanure <tanureal@...nsource.cirrus.com>
Cc:     "Rafael J . Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, <alsa-devel@...a-project.org>,
        <linux-acpi@...r.kernel.org>, <patches@...nsource.cirrus.com>,
        <platform-driver-x86@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/5] ALSA: hda: cs35l41: Tidyup code and add default cases

On Thu, 13 Jan 2022 18:07:27 +0100,
Lucas Tanure wrote:
> 
> Clean up the code, plus adding default cases for switch
> and dev_err_probe use.

Please split to patches.  There are too much mixed up of changes for
different goals.  There is difference between a white-space cleanup or
such (that is, no significant change of the resultant binary), a
cleanup with a better API usage, and a code refactoring.  And, the
addition of the missing default case is rather the fix, not a clean
up...


thanks,

Takashi