linux-kernel - Re: [PATCH v2 3/3] mmc: mediatek: add support for SDIO eint irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52901ebe0db555f8e58dc0d59cfd703c5a0fc2de.camel@mediatek.com>
Date:   Fri, 14 Jan 2022 11:06:36 +0800
From:   Axe Yang <axe.yang@...iatek.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     Ulf Hansson <ulf.hansson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Chaotian Jing <chaotian.jing@...iatek.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        "Yoshihiro Shimoda" <yoshihiro.shimoda.uh@...esas.com>,
        Satya Tangirala <satyat@...gle.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        "Lucas Stach" <dev@...xeye.de>, Eric Biggers <ebiggers@...gle.com>,
        Andrew Jeffery <andrew@...id.au>,
        Stephen Boyd <swboyd@...omium.org>,
        Kiwoong Kim <kwmad.kim@...sung.com>,
        Yue Hu <huyue2@...ong.com>, Tian Tao <tiantao6@...ilicon.com>,
        <linux-mmc@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v2 3/3] mmc: mediatek: add support for SDIO eint irq

On Thu, 2022-01-13 at 12:47 +0200, Andy Shevchenko wrote:
> On Thu, Jan 13, 2022 at 03:58:52PM +0800, Axe Yang wrote:
> 
> > But for the comment for 'dev_dbg', can you explain more about that?
> 
> Sure.
> 
> > On Tue, 2022-01-11 at 13:46 +0200, Andy Shevchenko wrote:
> > > On Tue, Jan 11, 2022 at 09:40:46AM +0800, Axe Yang wrote:
> 
> ..
> 
> > > > +		host->pins_eint = pinctrl_lookup_state(host-
> > > > >pinctrl,
> > > > "state_eint");
> > > > +		if (IS_ERR(host->pins_eint)) {
> > > > +			dev_dbg(&pdev->dev, "Cannot find
> > > > pinctrl
> > > > eint!\n");
> > > 
> > > In debug mode of pin control this will bring a duplicate message.
> > 
> > Can you explain more about this comment?
> > I don't understand what the 'duplicate message' refers for.
> 
> Have you chance to read the implementation of pinctrl_lookup_state()?

I have read pinctrl_lookup_state(), and if the 'duplicate message' you
were talking about is 'using pinctrl dummy state...':

https://elixir.bootlin.com/linux/latest/source/drivers/pinctrl/core.c#L1214
No, this message will not appear in debug mode if pins_eint not found
because pinctrl_dummy_state is always FALSE. MTK Soc do not need dummy
state support.

--
Best Regard,
Axe Yang