linux-kernel - RE: [EXTERNAL] Re: [PATCH 2/5] platform: surface: Propagate ACPI Dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 14 Jan 2022 17:11:39 +0000
From:   Jarrett Schultz <jaschultz@...rosoft.com>
To:     Felipe Balbi <balbi@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>
CC:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Jarrett Schultz <jaschultzms@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Mark Gross <markgross@...nel.org>,
        Maximilian Luz <luzmaximilian@...il.com>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: RE: [EXTERNAL] Re: [PATCH 2/5] platform: surface: Propagate ACPI
 Dependency

Hi,

> Felipe Balbi <balbi@...nel.org> writes: 
> 
> Hi,
> 
> Hans de Goede <hdegoede@...hat.com> writes:
> > Hi,
> >
> > On 1/14/22 09:29, Geert Uytterhoeven wrote:
> >> Hi Felipe,
> >>
> >> On Fri, Jan 14, 2022 at 7:21 AM Felipe Balbi <balbi@...nel.org> wrote:
> >>> Geert Uytterhoeven <geert@...ux-m68k.org> writes:
> >>>> On Mon, Dec 6, 2021 at 4:03 PM Jarrett Schultz
> <jaschultzms@...il.com> wrote:
> >>>>> Since the Surface XBL Driver does not depend on ACPI, the
> >>>>> platform/surface directory as a whole no longer depends on ACPI.
> >>>>> With respect to this, the ACPI dependency is moved into each
> >>>>> config that depends on ACPI individually.
> >>>>>
> >>>>> Signed-off-by: Jarrett Schultz <jaschultz@...rosoft.com>
> >>>>
> >>>> Thanks for your patch, which is now commit 272479928172edf0
> ("platform:
> >>>> surface: Propagate ACPI Dependency").
> >>>>
> >>>>> --- a/drivers/platform/surface/Kconfig
> >>>>> +++ b/drivers/platform/surface/Kconfig
> >>>>> @@ -5,7 +5,6 @@
> >>>>>
> >>>>>  menuconfig SURFACE_PLATFORMS
> >>>>>         bool "Microsoft Surface Platform-Specific Device Drivers"
> >>>>> -       depends on ACPI
> >>>>>         default y
> >>>>>         help
> >>>>>           Say Y here to get to see options for platform-specific
> >>>>> device drivers
> >>>>
> >>>> Without any dependency, all users configuring a kernel are now
> >>>> asked about this. Is there any other platform dependency that can
> >>>> be used instead?
> >>>
> >>> there's probably no symbol that would be true for x86 and arm64
> >>> while being false for everything else. Any ideas?
> >>
> >> depends on ARM64 || X86 || COMPILE_TEST?
> >
> > That sounds reasonable to me, I would be happy to take a patch for that.
> 
> fair enough, let's see what Jarrett replies
> 
> --
> Balbi

Sounds good to me, I'll include this in the next patch version. Thank you for pointing this out.

-Jarrett