linux-kernel - Re: [PATCH] module: fix signature check failures when using in-kernel decompression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YeG2Ky8nLGMIyqe3@bombadil.infradead.org>
Date:   Fri, 14 Jan 2022 09:43:07 -0800
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Jessica Yu <jeyu@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] module: fix signature check failures when using
 in-kernel decompression

On Thu, Jan 13, 2022 at 04:51:52PM -0800, Dmitry Torokhov wrote:
> The new flag MODULE_INIT_COMPRESSED_FILE unintentionally trips check in
> module_sig_check(). The check was supposed to catch case when version
> info or magic was removed from a signed module, making signature
> invalid, but it was coded too broadly and was catching this new flag as
> well.
> 
> Change the check to only test the 2 particular flags affecting signature
> validity.
> 
> Fixes: b1ae6dc41eaa ("module: add in-kernel support for decompressing")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Queued on to modules-next.

  Luis