linux-kernel - Re: [PATCH] NFS: Replace one-element array with flexible-array member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ad9ebec6db5bac36e3b486288b84c4e1bbd781f2.camel@hammerspace.com>
Date:   Fri, 14 Jan 2022 03:59:26 +0000
From:   Trond Myklebust <trondmy@...merspace.com>
To:     "cgel.zte@...il.com" <cgel.zte@...il.com>
CC:     "linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
        "deng.changcheng@....com.cn" <deng.changcheng@....com.cn>,
        "anna.schumaker@...app.com" <anna.schumaker@...app.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "zealci@....com.cn" <zealci@....com.cn>
Subject: Re: [PATCH] NFS: Replace one-element array with flexible-array member

On Fri, 2022-01-14 at 00:57 +0000, cgel.zte@...il.com wrote:
> From: Changcheng Deng <deng.changcheng@....com.cn>
> 
> There is a regular need in the kernel to provide a way to declare
> having
> a dynamically sized set of trailing elements in a structure. Kernel
> code
> should always use “flexible array members” for these cases. The older
> style of one-element or zero-length arrays should no longer be used.
> 
> Reference:
> https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length
> -
> and-one-element-arrays
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@....com.cn>
> ---
>  include/linux/nfs_xdr.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/nfs_xdr.h b/include/linux/nfs_xdr.h
> index 39390d9df9e1..7f51edd5785a 100644
> --- a/include/linux/nfs_xdr.h
> +++ b/include/linux/nfs_xdr.h
> @@ -421,7 +421,7 @@ struct nfs42_layout_error {
>         __u64 offset;
>         __u64 length;
>         nfs4_stateid stateid;
> -       struct nfs42_device_error errors[1];
> +       struct nfs42_device_error errors[];
>  };
>  
>  #define NFS42_LAYOUTERROR_MAX 5

NACK. This is a fixed size array of length 1, not a variable size
array. Please fix your tool.

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@...merspace.com