linux-kernel - [PATCH 1/2] ARM: dts: gemini: ns2502: permit to use gigabit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220115100444.3014823-1-clabbe@baylibre.com>
Date:   Sat, 15 Jan 2022 10:04:43 +0000
From:   Corentin Labbe <clabbe@...libre.com>
To:     linus.walleij@...aro.org, robh+dt@...nel.org,
        ulli.kroll@...glemail.com
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Corentin Labbe <clabbe@...libre.com>
Subject: [PATCH 1/2] ARM: dts: gemini: ns2502: permit to use gigabit

I believed that gigabit was not working due to some unknown missing GPIO.
In fact, gigabit worked when REALTEK_PHY was compiled out.
So the problem was due to PHY delay and we need to use rgmii-id.

Signed-off-by: Corentin Labbe <clabbe@...libre.com>
---
 arch/arm/boot/dts/gemini-ns2502.dts | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/gemini-ns2502.dts b/arch/arm/boot/dts/gemini-ns2502.dts
index 37e5debb693c..c759c4c732ab 100644
--- a/arch/arm/boot/dts/gemini-ns2502.dts
+++ b/arch/arm/boot/dts/gemini-ns2502.dts
@@ -39,10 +39,6 @@ mdio0: mdio {
 		phy0: ethernet-phy@1 {
 			reg = <1>;
 			device_type = "ethernet-phy";
-			/* We lack the knowledge of necessary GPIO to achieve
-			 * Gigabit
-			 */
-			max-speed = <100>;
 		};
 	};
 };
@@ -50,7 +46,7 @@ phy0: ethernet-phy@1 {
 &ethernet {
 	status = "okay";
 	ethernet-port@0 {
-		phy-mode = "rgmii";
+		phy-mode = "rgmii-id";
 		phy-handle = <&phy0>;
 		mac-address = [00 1F 1F 8E 65 E2];
 	};
-- 
2.34.1