linux-kernel - Re: [PATCH v2 1/1] ALSA: hda/realtek: fix speakers and micmute on HP 855 G8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 15 Jan 2022 23:47:40 +0800
From:   Kai-Heng Feng <kai.heng.feng@...onical.com>
To:     Alexander Sergeyev <sergeev917@...il.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Jeremy Szu <jeremy.szu@...onical.com>,
        Werner Sembach <wse@...edocomputers.com>,
        Hui Wang <hui.wang@...onical.com>,
        Cameron Berkenpas <cam@...-zeon.de>,
        Kailang Yang <kailang@...ltek.com>, Sami Loone <sami@...ne.fi>,
        Elia Devito <eliadevito@...il.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] ALSA: hda/realtek: fix speakers and micmute on HP
 855 G8

On Sat, Jan 15, 2022 at 12:46 AM Alexander Sergeyev
<sergeev917@...il.com> wrote:
>
> There are several PCI ids associated with HP EliteBook 855 G8 Notebook
> PC. Commit 0e68c4b11f1e6 ("ALSA: hda/realtek: fix mute/micmute LEDs for
> HP 855 G8") covers 0x103c:0x8896, while this commit covers 0x103c:0x8895
> which needs some additional work on top of the quirk from 0e68c4b11f1e6.
>
> Note that the device can boot up with working speakers and micmute LED
> without this patch, but the success rate would be quite low (order of
> 16 working boots across 709 boots) at least for the built-in drivers
> scenario. This also means that there are some timing issues during early
> boot and this patch is a workaround.
>
> With this patch applied speakers and headphones are consistenly working,
> as well as mute/micmute LEDs and the internal microphone.

Does this issue happen to warm boot (reboot) or cold boot?
If the issue only happen to warm boot, please try reverting commit
9d3fcb28f9b9 "Revert "PM: ACPI: reboot: Use S5 for reboot"".
Many HP systems requires it to have a functional reboot.

Kai-Heng

>
> Signed-off-by: Alexander Sergeyev <sergeev917@...il.com>
> ---
>  sound/pci/hda/patch_realtek.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index eef973661b0a..668274e52674 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6948,6 +6948,7 @@ enum {
>         ALC285_FIXUP_LEGION_Y9000X_AUTOMUTE,
>         ALC287_FIXUP_LEGION_16ACHG6,
>         ALC287_FIXUP_CS35L41_I2C_2,
> +       ALC285_FIXUP_HP_SPEAKERS_MICMUTE_LED,
>  };
>
>  static const struct hda_fixup alc269_fixups[] = {
> @@ -8698,6 +8699,16 @@ static const struct hda_fixup alc269_fixups[] = {
>                 .type = HDA_FIXUP_FUNC,
>                 .v.func = cs35l41_fixup_i2c_two,
>         },
> +       [ALC285_FIXUP_HP_SPEAKERS_MICMUTE_LED] = {
> +               .type = HDA_FIXUP_VERBS,
> +               .v.verbs = (const struct hda_verb[]) {
> +                        { 0x20, AC_VERB_SET_COEF_INDEX, 0x19 },
> +                        { 0x20, AC_VERB_SET_PROC_COEF, 0x8e11 },
> +                        { }
> +               },
> +               .chained = true,
> +               .chain_id = ALC285_FIXUP_HP_MUTE_LED,
> +       },
>  };
>
>  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> @@ -8911,6 +8922,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>         SND_PCI_QUIRK(0x103c, 0x8870, "HP ZBook Fury 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
>         SND_PCI_QUIRK(0x103c, 0x8873, "HP ZBook Studio 15.6 Inch G8 Mobile Workstation PC", ALC285_FIXUP_HP_GPIO_AMP_INIT),
>         SND_PCI_QUIRK(0x103c, 0x888d, "HP ZBook Power 15.6 inch G8 Mobile Workstation PC", ALC236_FIXUP_HP_GPIO_LED),
> +       SND_PCI_QUIRK(0x103c, 0x8895, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_SPEAKERS_MICMUTE_LED),
>         SND_PCI_QUIRK(0x103c, 0x8896, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_MUTE_LED),
>         SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
>         SND_PCI_QUIRK(0x103c, 0x88d0, "HP Pavilion 15-eh1xxx (mainboard 88D0)", ALC287_FIXUP_HP_GPIO_LED),
> --
> 2.34.1
>