linux-kernel - Re: [PATCH] regulator: MAX20086: add gpio/consumer.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YeL2zLp9jsbBqMYG@pendragon.ideasonboard.com>
Date:   Sat, 15 Jan 2022 18:31:08 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
        Watson Chow <watson.chow@...et.com>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH] regulator: MAX20086: add gpio/consumer.h

Hi Randy,

Thank you for the patch.

On Fri, Jan 14, 2022 at 07:36:03PM -0800, Randy Dunlap wrote:
> max20086-regulator.c needs <linux/gpio/consumer.h> for an enum, some
> macros, and a function prototype. (seen on ARCH=m68k)
> 
> Adding this header file fixes multiple build errors:
> 
> ../drivers/regulator/max20086-regulator.c: In function 'max20086_i2c_probe':
> ../drivers/regulator/max20086-regulator.c:217:26: error: storage size of 'flags' isn't known
>   217 |         enum gpiod_flags flags;
> ../drivers/regulator/max20086-regulator.c:261:27: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function); did you mean 'GPIOF_INIT_HIGH'?
>   261 |         flags = boot_on ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW;
>       |                           ^~~~~~~~~~~~~~
> ../drivers/regulator/max20086-regulator.c:261:44: error: 'GPIOD_OUT_LOW' undeclared (first use in this function); did you mean 'GPIOF_INIT_LOW'?
>   261 |         flags = boot_on ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW;
> ../drivers/regulator/max20086-regulator.c:262:27: error: implicit declaration of function 'devm_gpiod_get'; did you mean 'devm_gpio_free'? [-Werror=implicit-function-declaration]
>   262 |         chip->ena_gpiod = devm_gpiod_get(chip->dev, "enable", flags);
> ../drivers/regulator/max20086-regulator.c:217:26: warning: unused variable 'flags' [-Wunused-variable]
>   217 |         enum gpiod_flags flags;
> 
> Fixes: bfff546aae50 ("regulator: Add MAX20086-MAX20089 driver")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Watson Chow <watson.chow@...et.com>
> Cc: Mark Brown <broonie@...nel.org>
> Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/regulator/max20086-regulator.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20220114.orig/drivers/regulator/max20086-regulator.c
> +++ linux-next-20220114/drivers/regulator/max20086-regulator.c
> @@ -7,6 +7,7 @@
>  
>  #include <linux/err.h>
>  #include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/i2c.h>
>  #include <linux/module.h>
>  #include <linux/regmap.h>

-- 
Regards,

Laurent Pinchart