linux-kernel - Re: [PATCHv7 5/5] asm-generic/io: Add logging support for MMIO accessors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202201160019.hrsMYj6V-lkp@intel.com>
Date:   Sun, 16 Jan 2022 00:33:33 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sai Prakash Ranjan <quic_saipraka@...cinc.com>,
        Will Deacon <will@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Marc Zyngier <maz@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Steven Rostedt <rostedt@...dmis.org>
Cc:     kbuild-all@...ts.01.org, gregkh <gregkh@...uxfoundation.org>,
        quic_psodagud@...cinc.com, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCHv7 5/5] asm-generic/io: Add logging support for MMIO
 accessors

Hi Sai,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20220115]
[cannot apply to arm64/for-next/core arnd-asm-generic/master arm-perf/for-next/perf linus/master v5.16 v5.16-rc8 v5.16-rc7 v5.16]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sai-Prakash-Ranjan/lib-rwmmio-arm64-Add-support-to-trace-register-reads-writes/20220115-211708
base:    bd8d9cef2a7932e688ca267ea1adf5ea6557c777
config: nios2-defconfig (https://download.01.org/0day-ci/archive/20220116/202201160019.hrsMYj6V-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/0757812bba83a756f73ce1a84c86ded3e276cd0f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sai-Prakash-Ranjan/lib-rwmmio-arm64-Add-support-to-trace-register-reads-writes/20220115-211708
        git checkout 0757812bba83a756f73ce1a84c86ded3e276cd0f
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from arch/nios2/include/asm/io.h:41,
                    from include/linux/io.h:13,
                    from arch/nios2/include/asm/pgtable.h:18,
                    from include/linux/pgtable.h:6,
                    from arch/nios2/kernel/nios2_ksyms.c:11:
   include/asm-generic/io.h: In function 'readb':
>> include/asm-generic/io.h:181:32: error: '_THIS_IP_' undeclared (first use in this function)
     181 |         log_read_mmio(8, addr, _THIS_IP_);
         |                                ^~~~~~~~~
   include/asm-generic/io.h:181:32: note: each undeclared identifier is reported only once for each function it appears in
   include/asm-generic/io.h: In function 'readw':
   include/asm-generic/io.h:196:33: error: '_THIS_IP_' undeclared (first use in this function)
     196 |         log_read_mmio(16, addr, _THIS_IP_);
         |                                 ^~~~~~~~~
   include/asm-generic/io.h: In function 'readl':
   include/asm-generic/io.h:211:33: error: '_THIS_IP_' undeclared (first use in this function)
     211 |         log_read_mmio(32, addr, _THIS_IP_);
         |                                 ^~~~~~~~~
   include/asm-generic/io.h: In function 'writeb':
   include/asm-generic/io.h:241:40: error: '_THIS_IP_' undeclared (first use in this function)
     241 |         log_write_mmio(value, 8, addr, _THIS_IP_);
         |                                        ^~~~~~~~~
   include/asm-generic/io.h: In function 'writew':
   include/asm-generic/io.h:253:41: error: '_THIS_IP_' undeclared (first use in this function)
     253 |         log_write_mmio(value, 16, addr, _THIS_IP_);
         |                                         ^~~~~~~~~
   include/asm-generic/io.h: In function 'writel':
   include/asm-generic/io.h:265:41: error: '_THIS_IP_' undeclared (first use in this function)
     265 |         log_write_mmio(value, 32, addr, _THIS_IP_);
         |                                         ^~~~~~~~~


vim +/_THIS_IP_ +181 include/asm-generic/io.h

   169	
   170	/*
   171	 * {read,write}{b,w,l,q}() access little endian memory and return result in
   172	 * native endianness.
   173	 */
   174	
   175	#ifndef readb
   176	#define readb readb
   177	static inline u8 readb(const volatile void __iomem *addr)
   178	{
   179		u8 val;
   180	
 > 181		log_read_mmio(8, addr, _THIS_IP_);
   182		__io_br();
   183		val = __raw_readb(addr);
   184		__io_ar(val);
   185		log_post_read_mmio(val, 8, addr, _THIS_IP_);
   186		return val;
   187	}
   188	#endif
   189	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org