linux-kernel - Re: [PATCH] iio: adc: ad7124: fix mask used for setting AIN_BUFP & AIN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220115185615.403ee183@jic23-huawei>
Date:   Sat, 15 Jan 2022 18:56:15 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Cosmin Tanislav <demonsingur@...il.com>
Cc:     cosmin.tanislav@...log.com, Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ad7124: fix mask used for setting AIN_BUFP &
 AIN_BUFM bits

On Wed, 12 Jan 2022 22:00:36 +0200
Cosmin Tanislav <demonsingur@...il.com> wrote:

> According to page 90 of the datasheet [1], AIN_BUFP is bit 6 and
> AIN_BUFM is bit 5 of the CONFIG_0 -> CONFIG_7 registers.
> 
> Fix the mask used for setting these bits.
> 
> [1]: https://www.analog.com/media/en/technical-documentation/data-sheets/ad7124-8.pdf
> 
> Fixes: 0eaecea6e487 ("iio: adc: ad7124: Add buffered input support")
> Signed-off-by: Cosmin Tanislav <cosmin.tanislav@...log.com>
Curious that didn't cause problems anyone noticed before. Ah well.

Applied to the fixes-togreg branch of iio.git and marked for stable.

Note that branch will probably be rebased after rc1 as I have some
other things that need rc1 which will be in same pull request.

Jonathan

> ---
>  drivers/iio/adc/ad7124.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
> index e45c600fccc0..18c154afbd7a 100644
> --- a/drivers/iio/adc/ad7124.c
> +++ b/drivers/iio/adc/ad7124.c
> @@ -76,7 +76,7 @@
>  #define AD7124_CONFIG_REF_SEL(x)	FIELD_PREP(AD7124_CONFIG_REF_SEL_MSK, x)
>  #define AD7124_CONFIG_PGA_MSK		GENMASK(2, 0)
>  #define AD7124_CONFIG_PGA(x)		FIELD_PREP(AD7124_CONFIG_PGA_MSK, x)
> -#define AD7124_CONFIG_IN_BUFF_MSK	GENMASK(7, 6)
> +#define AD7124_CONFIG_IN_BUFF_MSK	GENMASK(6, 5)
>  #define AD7124_CONFIG_IN_BUFF(x)	FIELD_PREP(AD7124_CONFIG_IN_BUFF_MSK, x)
>  
>  /* AD7124_FILTER_X */