linux-kernel - Re: [PATCH 06/16] dt-bindings: serial: renesas,scif: Document RZ/V2L SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 15 Jan 2022 01:46:20 +0000
From:   "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Magnus Damm <magnus.damm@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>, Vinod Koul <vkoul@...nel.org>,
        Sergey Shtylyov <s.shtylyov@....ru>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Biju Das <biju.das.jz@...renesas.com>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-clk <linux-clk@...r.kernel.org>,
        dmaengine <dmaengine@...r.kernel.org>,
        netdev <netdev@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>
Subject: Re: [PATCH 06/16] dt-bindings: serial: renesas,scif: Document RZ/V2L SoC

Hi Geert,

Thank you for the review.

On Tue, Jan 11, 2022 at 4:23 PM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Tue, Dec 21, 2021 at 10:48 AM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@...renesas.com> wrote:
> > From: Biju Das <biju.das.jz@...renesas.com>
> >
> > Add SCIF binding documentation for Renesas RZ/V2L SoC. SCIF block on RZ/V2L
> > is identical to one found on the RZ/G2L SoC. No driver changes are required
> > as RZ/G2L compatible string "renesas,scif-r9a07g044" will be used as a
> > fallback.
> >
> > Signed-off-by: Biju Das <biju.das.jz@...renesas.com>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> > @@ -67,6 +67,12 @@ properties:
> >        - items:
> >            - enum:
> >                - renesas,scif-r9a07g044      # RZ/G2{L,LC}
> > +              - renesas,scif-r9a07g054      # RZ/V2L
>
> As the idea is to rely on the RZ/G2L fallback for matching, cfr. below,
> the above addition is not needed or wanted.
>
Agreed I will drop that.

> > +
> > +      - items:
> > +          - enum:
> > +              - renesas,scif-r9a07g054      # RZ/V2L
> > +          - const: renesas,scif-r9a07g044   # RZ/G2{L,LC} fallback for RZ/V2L
> >
> >    reg:
> >      maxItems: 1
> > @@ -154,6 +160,7 @@ if:
> >            - renesas,rcar-gen2-scif
> >            - renesas,rcar-gen3-scif
> >            - renesas,scif-r9a07g044
> > +          - renesas,scif-r9a07g054
>
> This addition is not needed if the fallback is always present.
>
Ditto.
> >  then:
> >    required:
> >      - resets
>
> Given Greg already applied your patch, I think you have to send a
> follow-up patch.
Will do.

Cheers,
Prabhakar