linux-kernel - Re: [PATCH 0/2] i2c: tegra: allow compiling out support for Tegra's special constrollers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YeRd90gLqtsz2zVV@qmqm.qmqm.pl>
Date:   Sun, 16 Jan 2022 19:03:35 +0100
From:   Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Jonathan Hunter <jonathanh@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Thierry Reding <thierry.reding@...il.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH 0/2] i2c: tegra: allow compiling out support for Tegra's
 special constrollers

On Sun, Jan 16, 2022 at 08:54:08PM +0300, Dmitry Osipenko wrote:
> 16.01.2022 19:02, Michał Mirosław пишет:
> > To patches that, combined, reduce I2C driver's code by ~2kB and a bit
> > from runtime overhead for non-Tegra20 or non-Tegra210 builds.
> > 
> > Michał Mirosław (2):
> >   i2c: tegra: allow DVC support to be compiled out
> >   i2c: tegra: allow VI support to be compiled out
> > 
> >  drivers/i2c/busses/Kconfig     | 16 ++++++++++++++++
> >  drivers/i2c/busses/i2c-tegra.c | 35 +++++++++++++++++++++-------------
> >  2 files changed, 38 insertions(+), 13 deletions(-)
> > 
> 
> 2KB is a too small difference to justify the ifdefs and Kconfig entries,
> IMO.

Maybe I should have mentioned that it's ~20%? With my "embedded" hat on:
I think it might be small, but sometimes it is the difference between
bootable kernel or one too big.

Best Regards
Michał Mirosław