lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 16 Jan 2022 15:36:01 +0800 From: Shuai Xue <xueshuai@...ux.alibaba.com> To: bp@...en8.de, rric@...nel.org Cc: mchehab@...nel.org, tony.luck@...el.com, james.morse@....com, ardb@...nel.org, linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org, linux-efi@...r.kernel.org, xueshuai@...ux.alibaba.com, zhangliguang@...ux.alibaba.com, zhuo.song@...ux.alibaba.com Subject: [PATCH v3 0/2] EDAC/ghes: refactor memory error reporting to avoid ghes_edac_report_mem_error() in ghes_edac.c is a Long Method and have Duplicated Code with cper_mem_err_location(), cper_dimm_err_location(), and cper_mem_err_type_str() in drivers/firmware/efi/cper.c. In addition, the cper_print_mem() in drivers/firmware/efi/cper.c only reports the error status and misses its description. This patch set is to refactor ghes_edac_report_mem_error with: - Patch 01 is to wrap up error status decoding logics and reuse it in cper_print_mem(). - Patch 02 is to introduces cper_*(), into ghes_edac_report_mem_error(), this can avoid bunch of duplicate code lines; Changes since v2: - delete the unified patch - adjust the order of patches - Link: https://lore.kernel.org/all/20211210134019.28536-1-xueshuai@linux.alibaba.com/ - Thanks Borislav Petkov for review comments. Changes since v1: - add a new patch to unify ghes and cper before removing duplication. - document the changes in patch description - add EXPORT_SYMBOL_GPL()s for cper_*() - document and the dependency and add UEFI_CPER dependency explicitly - Link: https://lore.kernel.org/all/20211207031905.61906-2-xueshuai@linux.alibaba.com/ - Thanks Robert Richter for review comments. Shuai Xue (2): efi/cper: add cper_mem_err_status_str to decode error description EDAC/ghes: use cper functions to avoid code duplication drivers/edac/Kconfig | 1 + drivers/edac/ghes_edac.c | 196 +++++++----------------------------- drivers/firmware/efi/cper.c | 82 +++++++++++---- include/linux/cper.h | 3 + 4 files changed, 102 insertions(+), 180 deletions(-) -- 2.20.1.12.g72788fdb
Powered by blists - more mailing lists