linux-kernel - Re: [PATCH] serial: liteuart: fix MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YePY7EO5iLmbhh3R@antec>
Date:   Sun, 16 Jan 2022 17:35:56 +0900
From:   Stafford Horne <shorne@...il.com>
To:     Alyssa Ross <hi@...ssa.is>
Cc:     Karol Gugala <kgugala@...micro.com>,
        Mateusz Holenko <mholenko@...micro.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Filip Kokosinski <fkokosinski@...micro.com>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: liteuart: fix MODULE_ALIAS

On Tue, Jan 04, 2022 at 01:10:28PM +0000, Alyssa Ross wrote:
> modprobe can't handle spaces in aliases.
> 
> Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver")
> Signed-off-by: Alyssa Ross <hi@...ssa.is>
> ---
>  drivers/tty/serial/liteuart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
> index 2941659e5274..7f74bf7bdcff 100644
> --- a/drivers/tty/serial/liteuart.c
> +++ b/drivers/tty/serial/liteuart.c
> @@ -436,4 +436,4 @@ module_exit(liteuart_exit);
>  MODULE_AUTHOR("Antmicro <www.antmicro.com>");
>  MODULE_DESCRIPTION("LiteUART serial driver");
>  MODULE_LICENSE("GPL v2");
> -MODULE_ALIAS("platform: liteuart");
> +MODULE_ALIAS("platform:liteuart");

This looks fine to me.

Acked-by: Stafford Horne <shorne@...il.com>

> base-commit: c9e6606c7fe92b50a02ce51dda82586ebdf99b48
> -- 
> 2.33.0
>