linux-kernel - Re: [PATCH] mfd: ipaq-micro: Fix IRQ check in micro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYrRv2aSL=7DbS5uMUKPq=wE354vs4Hky2iGvaMgo7_9g@mail.gmail.com>
Date:   Sun, 16 Jan 2022 13:08:12 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alessandro Gardich <gremlin@...mlin.it>,
        Dmitry Artamonow <mad_soft@...ox.ru>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: ipaq-micro: Fix IRQ check in micro_probe

On Fri, Jan 14, 2022 at 7:59 AM Miaoqian Lin <linmq006@...il.com> wrote:

> platform_get_irq() returns negative error number instead 0 on failure.
> And the doc of platform_get_irq() provides a usage example:
>
>     int irq = platform_get_irq(pdev, 0);
>     if (irq < 0)
>         return irq;
>
> Fix the check of return value to catch errors correctly.
>
> Fixes: dcc21cc09e3c ("mfd: Add driver for Atmel Microcontroller on iPaq h3xxx")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij