linux-kernel - Re: [PATCH v17 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <337655e4-db0c-e748-43bc-fd166c9f2577@quicinc.com>
Date:   Mon, 17 Jan 2022 10:16:24 -0800
From:   Kuogee Hsieh <quic_khsieh@...cinc.com>
To:     Stephen Boyd <swboyd@...omium.org>, <agross@...nel.org>,
        <airlied@...ux.ie>, <bjorn.andersson@...aro.org>,
        <daniel@...ll.ch>, <dmitry.baryshkov@...aro.org>,
        <dri-devel@...ts.freedesktop.org>, <robdclark@...il.com>,
        <sean@...rly.run>, <vkoul@...nel.org>
CC:     <quic_abhinavk@...cinc.com>, <aravindh@...eaurora.org>,
        <quic_sbillaka@...cinc.com>, <freedreno@...ts.freedesktop.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v17 1/4] drm/msm/dp: do not initialize phy until plugin
 interrupt received


On 1/14/2022 5:13 PM, Stephen Boyd wrote:
> Quoting Kuogee Hsieh (2022-01-14 16:58:32)
>> @@ -1363,14 +1368,14 @@ static int dp_pm_suspend(struct device *dev)
>>                  if (dp_power_clk_status(dp->power, DP_CTRL_PM))
>>                          dp_ctrl_off_link_stream(dp->ctrl);
>>
>> +               dp_display_host_phy_exit(dp);
>> +
>> +               /* host_init will be called at pm_resume */
>>                  dp_display_host_deinit(dp);
>>          }
> I thought we determined that core_initialized was always true here, so
> the if condition is redundant. Furthermore, removing that check allows
> us to entirely remove the core_initialized variable from the code.

my mistake. Will remove the condition check.

However, I would like to keep code_initialized for debugging purpose.

Otherwise, we will shot in the dark if customer report bug.