linux-kernel - Re: linux-next: build warning after merge of the origin tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJuCfpErqDrgEkw7OXyGTkfXiAEDHx=9DF9cW0qdc27Nm1_wrw@mail.gmail.com>
Date:   Sun, 16 Jan 2022 17:27:34 -0800
From:   Suren Baghdasaryan <surenb@...gle.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of the origin tree

On Sun, Jan 16, 2022 at 4:45 PM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Hi all,
>
> After merging the origin tree, today's linux-next build (powerpc
> allnoconfig) produced this warning:
>
> kernel/sysctl.c:125:12: warning: 'one_thousand' defined but not used [-Wunused-variable]
>   125 | static int one_thousand = 1000;
>       |            ^~~~~~~~~~~~
>
> Introduced by commit
>
>   39c65a94cd96 ("mm/pagealloc: sysctl: change watermark_scale_factor max limit to 30%")
>
> It seems to only be used when CONFIG_PERF_EVENTS is set.
>
> I didn't see it in linux-next because there is a patch later in the
> akpm series (not yet in Linus' tree) that removes this variable.

Sorry, I saw the warning before when backporting this patch but I
didn't realize that the followup patches refactoring this code would
not be merged.
Posted a fix at:
https://lore.kernel.org/all/20220117012317.21168-1-surenb@google.com/
Thanks!

>
> --
> Cheers,
> Stephen Rothwell