linux-kernel - Re: [PATCH] mtd: rawnand: protect access to rawnand devices while in suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220117085442.7f19182e@collabora.com>
Date:   Mon, 17 Jan 2022 08:54:42 +0100
From:   Boris Brezillon <boris.brezillon@...labora.com>
To:     Sean Nyekjaer <sean@...nix.com>
Cc:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Boris Brezillon <bbrezillon@...nel.org>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: rawnand: protect access to rawnand devices while
 in suspend

On Mon, 17 Jan 2022 08:43:39 +0100
Sean Nyekjaer <sean@...nix.com> wrote:

> On Mon, Dec 20, 2021 at 02:00:15PM +0100, Sean Nyekjaer wrote:
> > Prevent rawnend access while in a suspended state.
> > 
> > Commit 013e6292aaf5 ("mtd: rawnand: Simplify the locking") allows the
> > rawnand layer to return errors rather than waiting in a blocking wait.
> > 
> > Tested on a iMX6ULL.
> > 
> > Fixes: 013e6292aaf5 ("mtd: rawnand: Simplify the locking")
> > Signed-off-by: Sean Nyekjaer <sean@...nix.com>
> > ---  
> 
> Hi Boris and Miquel,
> 
> I know the kernel test robot is complaining a bit about uninitialized
> values.
> But is this OK? If I fix the unitialized values?

With the 'uninitialized ret' issue fixed, it looks good to me:

Reviewed-by: Boris Brezillon <boris.brezillon@...labora.com>

But you probably want to add a Cc:stable tag.