linux-kernel - Re: [PATCH 20/23] dt-bindings: iio: adc: exynos-adc: Add ADC-V3 variant

Open Source and information security mailing list archives

Message-ID: <20220117094728.000051b8@Huawei.com>
Date:   Mon, 17 Jan 2022 09:47:28 +0000
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
CC:     Alim Akhtar <alim.akhtar@...sung.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <soc@...nel.org>,
        <linux-clk@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <olof@...om.net>, <linus.walleij@...aro.org>,
        <catalin.marinas@....com>, <robh+dt@...nel.org>,
        <s.nawrocki@...sung.com>, <linux-samsung-soc@...r.kernel.org>,
        <pankaj.dubey@...sung.com>, <linux-fsd@...la.com>,
        Tamseel Shams <m.shams@...sung.com>
Subject: Re: [PATCH 20/23] dt-bindings: iio: adc: exynos-adc: Add ADC-V3
 variant

On Thu, 13 Jan 2022 14:32:12 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com> wrote:

> On 13/01/2022 13:11, Alim Akhtar wrote:
> > This patch adds a new compatible string for exynos's ADC-V3 variant.
> > 
> > Cc: linux-fsd@...la.com
> > Signed-off-by: Tamseel Shams <m.shams@...sung.com>
> > Signed-off-by: Alim Akhtar <alim.akhtar@...sung.com>

Please cc linux-iio@...r.kernel.org for next version...

> > ---
> >  .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml          | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> > index 81c87295912c..9303053759ca 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> > @@ -14,6 +14,7 @@ properties:
> >      enum:
> >        - samsung,exynos-adc-v1                 # Exynos5250
> >        - samsung,exynos-adc-v2
> > +      - samsung,exynos-adc-v3  
> 
> Please use SoC-specific compatible. IP block versions are tricky because:
> 1. Documentation/datasheet mentioning which SoC has which block version
> are not public.
> 2. Neither are public the datasheets for ADC blocks.
> 3. The versioning of IP blocks can be inaccurate.
> 
> 
> Best regards,
> Krzysztof
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives