linux-kernel - Re: [PATCH v2 0/2] Clock based PWM output driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220117121000.3lgohyenamvwmcur@pengutronix.de>
Date:   Mon, 17 Jan 2022 13:10:00 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Nikita Travkin <nikita@...n.ru>
Cc:     thierry.reding@...il.com, lee.jones@...aro.org, robh+dt@...nel.org,
        sboyd@...nel.org, linus.walleij@...aro.org, masneyb@...tation.org,
        linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v2 0/2] Clock based PWM output driver

Hello Nikita,

On Mon, Dec 13, 2021 at 08:03:33PM +0500, Nikita Travkin wrote:
> This series introduces an "adapter" driver that allows PWM consumers
> to control clock outputs with duty-cycle control.
> 
> Some platforms (e.g. some Qualcomm chipsets) have "General Purpose"
> clocks that can be muxed to GPIO outputs and used as PWM outputs. 
> Those outputs may be connected to various peripherals such as
> leds in display backlight or haptic feedback motor driver. 
> 
> To avoid re-implementing every single PWM consumer driver with clk
> support (like in [1]) and don't put the burden of providing the PWM
> sources on the clock drivers (as was proposed in [2]), clk based
> pwm controller driver is introduced.
> 
> There is an existing driver that provides the opposite function
> in drivers/clk/clk-pwm.c with a compatible "pwm-clock" so the new
> driver uses the opposite naming scheme: drivers/pwm/pwm-clk.c
> and compatible "clk-pwm". 

You got some feedback on your patches and didn't respond to it. Are you
interested to improve your patch set? If yes, I'm willing to review more
deeply. If not, I'm not.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)