linux-kernel - [irqchip: irq/irqchip-fixes] irqchip/realtek-rtl: Map control data to virq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <164242226169.16921.10741933704404329926.tip-bot2@tip-bot2>
Date:   Mon, 17 Jan 2022 12:24:21 -0000
From:   "irqchip-bot for Sander Vanheule" <tip-bot2@...utronix.de>
To:     linux-kernel@...r.kernel.org
Cc:     Sander Vanheule <sander@...nheule.net>,
        Marc Zyngier <maz@...nel.org>, tglx@...utronix.de
Subject: [irqchip: irq/irqchip-fixes] irqchip/realtek-rtl: Map control data to virq

The following commit has been merged into the irq/irqchip-fixes branch of irqchip:

Commit-ID:     291e79c7e2eb6fdc016453597b78482e06199d0f
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/291e79c7e2eb6fdc016453597b78482e06199d0f
Author:        Sander Vanheule <sander@...nheule.net>
AuthorDate:    Sun, 09 Jan 2022 15:54:32 +01:00
Committer:     Marc Zyngier <maz@...nel.org>
CommitterDate: Mon, 17 Jan 2022 12:13:58 

irqchip/realtek-rtl: Map control data to virq

The driver assigned the irqchip and irq handler to the hardware irq,
instead of the virq. This is incorrect, and only worked because these
irq numbers happened to be the same on the devices used for testing the
original driver.

Fixes: 9f3a0f34b84a ("irqchip: Add support for Realtek RTL838x/RTL839x interrupt controller")
Signed-off-by: Sander Vanheule <sander@...nheule.net>
Signed-off-by: Marc Zyngier <maz@...nel.org>
Link: https://lore.kernel.org/r/4b4936606480265db47df152f00bc2ed46340599.1641739718.git.sander@svanheule.net
---
 drivers/irqchip/irq-realtek-rtl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-realtek-rtl.c b/drivers/irqchip/irq-realtek-rtl.c
index fd9f275..d6788dd 100644
--- a/drivers/irqchip/irq-realtek-rtl.c
+++ b/drivers/irqchip/irq-realtek-rtl.c
@@ -62,7 +62,7 @@ static struct irq_chip realtek_ictl_irq = {
 
 static int intc_map(struct irq_domain *d, unsigned int irq, irq_hw_number_t hw)
 {
-	irq_set_chip_and_handler(hw, &realtek_ictl_irq, handle_level_irq);
+	irq_set_chip_and_handler(irq, &realtek_ictl_irq, handle_level_irq);
 
 	return 0;
 }