linux-kernel - Re: [PATCH] ath11k: fix error handling in ath11k_qmi_assign_target_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <164242442618.16718.73054650971271178.kvalo@kernel.org>
Date:   Mon, 17 Jan 2022 13:00:27 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     trix@...hat.com
Cc:     davem@...emloft.net, kuba@...nel.org, nathan@...nel.org,
        ndesaulniers@...gle.com, akolli@...eaurora.org,
        ath11k@...ts.infradead.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev, Tom Rix <trix@...hat.com>
Subject: Re: [PATCH] ath11k: fix error handling in
 ath11k_qmi_assign_target_mem_chunk()

trix@...hat.com wrote:

> From: Tom Rix <trix@...hat.com>
> 
> Clang static analysis reports this problem
> qmi.c:1935:5: warning: Undefined or garbage value returned to caller
>   return ret;
>   ^~~~~~~~~~
> 
> ret is uninitialized.  When of_parse_phandle() fails, garbage is
> returned.  So return -EINVAL.
> 
> Fixes: 6ac04bdc5edb ("ath11k: Use reserved host DDR addresses from DT for PCI devices")
> Signed-off-by: Tom Rix <trix@...hat.com>

I just applied a fix from Dan:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=c9b41832dc08

Patch set to Superseded.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220116144206.399385-1-trix@redhat.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches