linux-kernel - Re: [PATCH] usb: common: ulpi: Fix crash in ulpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <170d3614-97e3-8494-ac87-37d11dc48770@nvidia.com>
Date:   Mon, 17 Jan 2022 15:01:55 +0000
From:   Jon Hunter <jonathanh@...dia.com>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     Stephan Gerhold <stephan@...hold.net>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH] usb: common: ulpi: Fix crash in ulpi_match()

Hi Heikki,

On 17/01/2022 14:10, Heikki Krogerus wrote:
> Hi Jon,
> 
> On Fri, Jan 14, 2022 at 10:02:17AM +0000, Jon Hunter wrote:
>> Commit 7495af930835 ("ARM: multi_v7_defconfig: Enable drivers for
>> DragonBoard 410c") enables the CONFIG_PHY_QCOM_USB_HS for the ARM
>> multi_v7_defconfig. Enabling this Kconfig is causing the kernel to crash
>> on the Tegra20 Ventana platform in the ulpi_match() function.
>>
>> The Qualcomm USB HS PHY driver that is enabled by CONFIG_PHY_QCOM_USB_HS,
>> registers a ulpi_driver but this driver does not provide an 'id_table',
>> so when ulpi_match() is called on the Tegra20 Ventana platform, it
>> crashes when attempting to deference the id_table pointer which is not
>> valid. The Qualcomm USB HS PHY driver uses device-tree for matching the
>> ULPI driver with the device and so fix this crash by using device-tree
>> for matching if the id_table is not valid.
>>
>> Signed-off-by: Jon Hunter <jonathanh@...dia.com>
> 
> So is this fixing commit 7495af930835, or perhaps commit ef6a7bcfb01c
> ("usb: ulpi: Support device discovery via DT")?
> 
> I would assume ef6a7bcfb01c ("usb: ulpi: Support device discovery via
> DT"). Please include the appropriate Fixes tag.


Yes that does sound appropriate. I have added and sent an update.

Cheers
Jon

-- 
nvpublic