linux-kernel - [mingo-tip:sched/headers 111/2384] include/linux/thread_info.h:68:20: error: redefinition of 'set_restart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202201180017.awOuzVzR-lkp@intel.com>
Date:   Tue, 18 Jan 2022 00:10:47 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: [mingo-tip:sched/headers 111/2384]
 include/linux/thread_info.h:68:20: error: redefinition of 'set_restart_fn'

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git sched/headers
head:   4c707c1c0de83967079b4e385012fa5b00e2cd11
commit: 7d7e24a8155b9ee4b8c93b14489476ce906788d3 [111/2384] headers/deps: kernel: Split <linux/restart_block.h> into <linux/restart_block_types.h> and <linux/restart_block_api.h>
config: i386-randconfig-a014-20220109 (https://download.01.org/0day-ci/archive/20220118/202201180017.awOuzVzR-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 5f782d25a742302d25ef3c8b84b54f7483c2deb9)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git/commit/?id=7d7e24a8155b9ee4b8c93b14489476ce906788d3
        git remote add mingo-tip git://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git
        git fetch --no-tags mingo-tip sched/headers
        git checkout 7d7e24a8155b9ee4b8c93b14489476ce906788d3
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 prepare

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

Note: the mingo-tip/sched/headers HEAD 4c707c1c0de83967079b4e385012fa5b00e2cd11 builds fine.
      It only hurts bisectability.

All errors (new ones prefixed by >>):

   In file included from arch/x86/kernel/asm-offsets.c:9:
   In file included from arch/x86/kernel/../../../kernel/sched/per_task_area_struct.h:7:
   In file included from include/linux/sched.h:17:
   In file included from include/linux/rbtree.h:24:
   In file included from include/linux/rcupdate.h:27:
   In file included from include/linux/preempt.h:78:
   In file included from arch/x86/include/asm/preempt.h:7:
>> include/linux/thread_info.h:68:20: error: redefinition of 'set_restart_fn'
   static inline long set_restart_fn(struct restart_block *restart,
                      ^
   include/linux/restart_block_api.h:23:20: note: previous definition is here
   static inline long set_restart_fn(struct restart_block *restart,
                      ^
   In file included from arch/x86/kernel/asm-offsets.c:34:
   arch/x86/kernel/../../../kernel/sched/per_task_area_struct_defs.h:13:13: warning: no previous prototype for function 'per_task_common' [-Wmissing-prototypes]
   void __used per_task_common(void)
               ^
   arch/x86/kernel/../../../kernel/sched/per_task_area_struct_defs.h:13:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void __used per_task_common(void)
   ^
   static 
   1 warning and 1 error generated.
   make[2]: *** [scripts/Makefile.build:121: arch/x86/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1197: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:219: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.


vim +/set_restart_fn +68 include/linux/thread_info.h

5abbe51a526253 Oleg Nesterov 2021-02-01  67  
5abbe51a526253 Oleg Nesterov 2021-02-01 @68  static inline long set_restart_fn(struct restart_block *restart,
5abbe51a526253 Oleg Nesterov 2021-02-01  69  					long (*fn)(struct restart_block *))
5abbe51a526253 Oleg Nesterov 2021-02-01  70  {
5abbe51a526253 Oleg Nesterov 2021-02-01  71  	restart->fn = fn;
5abbe51a526253 Oleg Nesterov 2021-02-01  72  	arch_set_restart_data(restart);
5abbe51a526253 Oleg Nesterov 2021-02-01  73  	return -ERESTART_RESTARTBLOCK;
5abbe51a526253 Oleg Nesterov 2021-02-01  74  }
5abbe51a526253 Oleg Nesterov 2021-02-01  75  

:::::: The code at line 68 was first introduced by commit
:::::: 5abbe51a526253b9f003e9a0a195638dc882d660 kernel, fs: Introduce and use set_restart_fn() and arch_set_restart_data()

:::::: TO: Oleg Nesterov <oleg@...hat.com>
:::::: CC: Thomas Gleixner <tglx@...utronix.de>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org