linux-kernel - Re: [PATCH V3 1/7] dt-bindings: Add the yaml bindings for EUD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ffda32f9-85ff-b6d2-0736-6c36d6c709ec@quicinc.com>
Date:   Mon, 17 Jan 2022 10:42:20 +0530
From:   Souradeep Chowdhury <quic_schowdhu@...cinc.com>
To:     Rob Herring <robh@...nel.org>
CC:     <linux-arm-msm@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <pure.logic@...us-software.ie>,
        <bjorn.andersson@...aro.org>, <greg@...ah.com>,
        <linux-kernel@...r.kernel.org>, <tsoni@...eaurora.org>,
        <psodagud@...eaurora.org>, <satyap@...eaurora.org>,
        <pheragu@...eaurora.org>, <rnayak@...eaurora.org>,
        <sibis@...eaurora.org>, <saiprakash.ranjan@...eaurora.org>
Subject: Re: [PATCH V3 1/7] dt-bindings: Add the yaml bindings for EUD


On 1/12/2022 6:38 AM, Rob Herring wrote:
> On Tue, Jan 04, 2022 at 05:28:14PM +0530, Souradeep Chowdhury wrote:
>> Documentation for Embedded USB Debugger(EUD) device tree
>> bindings in yaml format.
> I agree with Bjorn's comments.
Ack
>
>> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@...cinc.com>
>> ---
>>   .../devicetree/bindings/soc/qcom/qcom,eud.yaml     | 50 ++++++++++++++++++++++
>>   1 file changed, 50 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
>> new file mode 100644
>> index 0000000..3523932
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
>> @@ -0,0 +1,50 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/soc/qcom/qcom,eud.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: Qualcomm Embedded USB Debugger
>> +
>> +maintainers:
>> +  - Souradeep Chowdhury <quic_schowdhu@...cinc.com>
>> +
>> +description:
>> +  This binding is used to describe the Qualcomm Embedded USB Debugger, which is
>> +  mini USB-hub implemented on chip to support USB-based debug capabilities.
>> +
>> +properties:
>> +  compatible:
>> +    items:
>> +      - enum:
>> +          - qcom,sc7280-eud
>> +      - const: qcom,eud
>> +
>> +  reg:
>> +    items:
>> +      - description: EUD Base Register Region
>> +      - description: EUD Mode Manager Register
>> +
>> +  interrupts:
>> +    description:
>> +      EUD interrupt
> Just 'maxItems: 1' is sufficient here.
Ack
>
>> +
>> +  port:
> Based on Bjorn's comment, you will need 2 port nodes.
Ack
>
>> +    description:
>> +      This port is to be attached to the endpoint of the connector child of
>> +      DWC3 controller node. The controller has the "usb-role-switch" property.
>> +    $ref: /schemas/graph.yaml#/properties/port
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    eud@...0000 {
>> +           compatible = "qcom,sc7280-eud","qcom,eud";
>> +           reg = <0x88e0000 0x2000>,
>> +                 <0x88e2000 0x1000>;
> Are the ports really optional?
Ack. Will make them mandatory.
>
>> +    };
>> -- 
>> 2.7.4
>>
>>