linux-kernel - Re: [PATCH] arch/s390/kernel: remove unneeded rc variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Jan 2022 10:15:30 +0100
From:   Heiko Carstens <hca@...ux.ibm.com>
To:     cgel.zte@...il.com
Cc:     oleg@...hat.com, gor@...ux.ibm.com, borntraeger@...ux.ibm.com,
        agordeev@...ux.ibm.com, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org, Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] arch/s390/kernel: remove unneeded rc variable

On Tue, Jan 18, 2022 at 07:51:15AM +0000, cgel.zte@...il.com wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Return value from user_regset_copyin() directly instead
> of taking this in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@...il.com>
> ---
>  arch/s390/kernel/ptrace.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
...
> -	int rc;
> -
>  	if (!MACHINE_HAS_VX)
>  		return -ENODEV;
>  	if (target == current)
>  		save_fpu_regs();
>  
> -	rc = user_regset_copyin(&pos, &count, &kbuf, &ubuf,
> +	return user_regset_copyin(&pos, &count, &kbuf, &ubuf,
>  				target->thread.fpu.vxrs + __NUM_VXRS_LOW, 0, -1);
> -	return rc;

This "breaks" indentation. Could you guys please stop sending such
semi-automated generated questionable patches? I really don't see any
benefit besides code churn, and the possibility of introducing bugs.

Thanks!