linux-kernel - Re: Re: [PATCH] driver core: Add missing pm_runtime_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3861fca1.2105f.17e6cd545c0.Coremail.lyz_cs@pku.edu.cn>
Date:   Tue, 18 Jan 2022 18:57:03 +0800 (GMT+08:00)
From:   刘永志 <lyz_cs@....edu.cn>
To:     "rafael j. wysocki" <rafael@...nel.org>
Cc:     "greg kroah-hartman" <gregkh@...uxfoundation.org>,
        "linux kernel mailing list" <linux-kernel@...r.kernel.org>
Subject: Re: Re: [PATCH] driver core: Add missing pm_runtime_put_noidle

> -----原始邮件-----
> 发件人: "Rafael J. Wysocki" <rafael@...nel.org>
> 发送时间: 2022-01-17 22:01:54 (星期一)
> 收件人: "Yongzhi Liu" <lyz_cs@....edu.cn>
> 抄送: "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>, "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
> 主题: Re: [PATCH] driver core: Add missing pm_runtime_put_noidle
> 
> On Mon, Jan 17, 2022 at 12:08 PM Yongzhi Liu <lyz_cs@....edu.cn> wrote:
> >
> > pm_runtime_get_noresume() in device_shutdown increments the
> > runtime PM usage counter,
> 
> This is on purpose, to prevent devices from being runtime-suspended
> after their shutdown callbacks have run.
> 
> > thus a matching decrement is needed
> 
> No, it is not, AFAICS.
> 
> > to keep the counter balanced.
> >
> > Signed-off-by: Yongzhi Liu <lyz_cs@....edu.cn>
> > ---
> >  drivers/base/core.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/base/core.c b/drivers/base/core.c
> > index fd034d7..29950bd 100644
> > --- a/drivers/base/core.c
> > +++ b/drivers/base/core.c
> > @@ -4523,6 +4523,8 @@ void device_shutdown(void)
> >                         dev->driver->shutdown(dev);
> >                 }
> >
> > +               pm_runtime_put_noidle(dev);
> > +
> >                 device_unlock(dev);
> >                 if (parent)
> >                         device_unlock(parent);
> > --
> > 2.7.4
> >
Yes, thanks for your reply.