[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1642507272-17545-1-git-send-email-lyz_cs@pku.edu.cn>
Date: Tue, 18 Jan 2022 04:01:12 -0800
From: Yongzhi Liu <lyz_cs@....edu.cn>
To: airlied@...ux.ie, daniel@...ll.ch, nirmoy.das@....com,
lijo.lazar@....com, Jingwen.Chen2@....com, evan.quan@....com,
Jack.Zhang1@....com, kevin1.wang@....com, tom.stdenis@....com
Cc: amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org, Yongzhi Liu <lyz_cs@....edu.cn>
Subject: [PATCH] drm/amdgpu: Add missing pm_runtime_put_autosuspend
pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code, thus a matching decrement is needed
on the error handling path to keep the counter balanced.
Signed-off-by: Yongzhi Liu <lyz_cs@....edu.cn>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
index 9aea1cc..4b950de 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
@@ -1120,8 +1120,10 @@ static ssize_t amdgpu_debugfs_gfxoff_read(struct file *f, char __user *buf,
return -EINVAL;
r = pm_runtime_get_sync(adev_to_drm(adev)->dev);
- if (r < 0)
+ if (r < 0) {
+ pm_runtime_put_autosuspend(adev_to_drm(adev)->dev);
return r;
+ }
while (size) {
uint32_t value;
--
2.7.4
Powered by blists - more mailing lists