linux-kernel - Re: [PATCH] printk: Fix seq check inside devkmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874k61xjrx.fsf@jogness.linutronix.de>
Date:   Tue, 18 Jan 2022 14:26:34 +0106
From:   John Ogness <john.ogness@...utronix.de>
To:     Mukesh Ojha <quic_mojha@...cinc.com>, linux-kernel@...r.kernel.org
Cc:     rostedt@...dmis.org, senozhatsky@...omium.org, pmladek@...e.com,
        Mukesh Ojha <quic_mojha@...cinc.com>
Subject: Re: [PATCH] printk: Fix seq check inside devkmsg_read()

On 2022-01-18, Mukesh Ojha <quic_mojha@...cinc.com> wrote:
> prb_read_valid() could return a record whose seq number can be
> newer than the requested one. In that case, we allow the reading
> of the data instead of erroring out.

The EPIPE error is intentional. It informs the devkmsg reader that a
record was missed.

For simple readers, like cat(1), this means that the kernel messages
cannot be read completely reliably. We talked about this a while back
[0] because initially I wanted to do what your patch does. In the end it
was agreed that readers of /dev/kmsg must implement EPIPE handling for
missed records.

John Ogness

[0] https://lore.kernel.org/all/87pneiyv12.fsf@linutronix.de