linux-kernel - Re: [PATCH] net: phy: micrel: use kszphy_suspend()/kszphy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YebCQZJ/RQYrh81j@lunn.ch>
Date:   Tue, 18 Jan 2022 14:36:01 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Claudiu Beznea <claudiu.beznea@...rochip.com>
Cc:     hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
        kuba@...nel.org, ioana.ciornei@....com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: micrel: use kszphy_suspend()/kszphy_resume for
 irq aware devices

On Tue, Jan 18, 2022 at 01:08:12PM +0200, Claudiu Beznea wrote:
> On a setup with KSZ9131 and MACB drivers it happens on suspend path, from
> time to time, that the PHY interrupt arrives after PHY and MACB were
> suspended (PHY via genphy_suspend(), MACB via macb_suspend()). In this
> case the phy_read() at the beginning of kszphy_handle_interrupt() will
> fail (as MACB driver is suspended at this time) leading to phy_error()
> being called and a stack trace being displayed on console. To solve this
> .suspend/.resume functions for all KSZ devices implementing
> .handle_interrupt were replaced with kszphy_suspend()/kszphy_resume()
> which disable/enable interrupt before/after calling
> genphy_suspend()/genphy_resume().
> 
> The fix has been adapted for all KSZ devices which implements
> .handle_interrupt but it has been tested only on KSZ9131.
> 
> Fixes: 59ca4e58b917 ("net: phy: micrel: implement generic .handle_interrupt() callback")
> Signed-off-by: Claudiu Beznea <claudiu.beznea@...rochip.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew