linux-kernel - Re: [PATCH AUTOSEL 5.16 047/217] cirrus: mac89x0: use eth_hw_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220118085641.6c0c7cc9@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 18 Jan 2022 08:56:41 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 5.16 047/217] cirrus: mac89x0: use
 eth_hw_addr_set()

On Mon, 17 Jan 2022 21:16:50 -0500 Sasha Levin wrote:
> From: Jakub Kicinski <kuba@...nel.org>
> 
> [ Upstream commit 9a962aedd30f7fceb828d3161a80e0526e358eb5 ]
> 
> Byte by byte assignments.
> 
> Fixes build on m68k.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> Signed-off-by: Sasha Levin <sashal@...nel.org>

Hi Sasha! You can drop all the eth_hw_addr_set() patches.
They aren't fixes, I should have used a different verb, the point 
was to mention the arch where the driver is built. The patches are 
only needed in 5.17 where netdev->dev_addr becomes a const.

I think that's patches 34-47, 53.