linux-kernel - Re: [PATCH RFT] net: asix: add proper error handling of usb read errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5431144f-62d4-23f8-c60b-c11c52863c66@gmail.com>
Date:   Tue, 18 Jan 2022 22:00:28 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     davem@...emloft.net, kuba@...nel.org, linux@...pel-privat.de,
        andrew@...n.ch, oneukum@...e.com, robert.foss@...labora.com,
        freddy@...x.com.tw, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzbot+6ca9f7867b77c2d316ac@...kaller.appspotmail.com
Subject: Re: [PATCH RFT] net: asix: add proper error handling of usb read
 errors

Hi Greg,

On 1/18/22 09:18, Greg KH wrote:
> On Mon, Jan 17, 2022 at 10:31:21PM +0300, Pavel Skripkin wrote:
>> On 1/5/22 16:19, Pavel Skripkin wrote:
>> > Syzbot once again hit uninit value in asix driver. The problem still the
>> > same -- asix_read_cmd() reads less bytes, than was requested by caller.
>> > 
>> > Since all read requests are performed via asix_read_cmd() let's catch
>> > usb related error there and add __must_check notation to be sure all
>> > callers actually check return value.
>> > 
>> > So, this patch adds sanity check inside asix_read_cmd(), that simply
>> > checks if bytes read are not less, than was requested and adds missing
>> > error handling of asix_read_cmd() all across the driver code.
>> > 
>> > Fixes: d9fe64e51114 ("net: asix: Add in_pm parameter")
>> > Reported-and-tested-by: syzbot+6ca9f7867b77c2d316ac@...kaller.appspotmail.com
>> > Signed-off-by: Pavel Skripkin <paskripkin@...il.com>
>> > ---
>> 
>> gentle ping :)
> 
> It's the middle of a merge window, and you ask for testing before it can
> be applied?
> 

I indeed lost track of days, sorry for bothering during merge window, my 
bad.

FYI, this patch was tested by Oleksij [1], that why I decided to ping, 
but as I said I lost track of days a bit

[1] https://lore.kernel.org/all/20220105141535.GI303@pengutronix.de/


With regards,
Pavel Skripkin