[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CADnq5_M7SqB_OjKaYaqKvdC=8xAo=Zn4NFzAuPxZrKPEOJtU8w@mail.gmail.com>
Date: Tue, 18 Jan 2022 15:13:39 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: "Lazar, Lijo" <lijo.lazar@....com>
Cc: Yongzhi Liu <lyz_cs@....edu.cn>, Dave Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
Nirmoy Das <nirmoy.das@....com>,
Jingwen Chen <Jingwen.Chen2@....com>,
"Quan, Evan" <evan.quan@....com>, Jack Zhang <Jack.Zhang1@....com>,
Kevin Wang <kevin1.wang@....com>,
Tom St Denis <tom.stdenis@....com>,
Maling list - DRI developers
<dri-devel@...ts.freedesktop.org>,
amd-gfx list <amd-gfx@...ts.freedesktop.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amdgpu: Add missing pm_runtime_put_autosuspend
Applied. Strangely I can't seem to find this patch in my inbox or in
the dri-devel or amd-gfx archives.
Alex
On Tue, Jan 18, 2022 at 9:03 AM Lazar, Lijo <lijo.lazar@....com> wrote:
>
>
>
> On 1/18/2022 5:31 PM, Yongzhi Liu wrote:
> > pm_runtime_get_sync() increments the runtime PM usage counter even
> > when it returns an error code, thus a matching decrement is needed
> > on the error handling path to keep the counter balanced.
> >
> > Signed-off-by: Yongzhi Liu <lyz_cs@....edu.cn>
>
> Thanks!
>
> Reviewed-by: Lijo Lazar <lijo.lazar@....com>
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> > index 9aea1cc..4b950de 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> > @@ -1120,8 +1120,10 @@ static ssize_t amdgpu_debugfs_gfxoff_read(struct file *f, char __user *buf,
> > return -EINVAL;
> >
> > r = pm_runtime_get_sync(adev_to_drm(adev)->dev);
> > - if (r < 0)
> > + if (r < 0) {
> > + pm_runtime_put_autosuspend(adev_to_drm(adev)->dev);
> > return r;
> > + }
> >
> > while (size) {
> > uint32_t value;
> >
Powered by blists - more mailing lists