linux-kernel - fs/notify/fanotify/fanotify_user.c:154:24: warning: variable 'info' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Wed, 19 Jan 2022 04:34:01 +0800
From:   kernel test robot <lkp@...el.com>
To:     Amir Goldstein <amir73il@...il.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Jan Kara <jack@...e.cz>
Subject: fs/notify/fanotify/fanotify_user.c:154:24: warning: variable 'info'
 set but not used

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   99613159ad749543621da8238acf1a122880144e
commit: 7326e382c21e9c23c89c88369afdc90b82a14da8 fanotify: report old and/or new parent+name in FAN_RENAME event
date:   5 weeks ago
config: x86_64-randconfig-m001-20220117 (https://download.01.org/0day-ci/archive/20220119/202201190416.xidpRFf8-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7326e382c21e9c23c89c88369afdc90b82a14da8
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 7326e382c21e9c23c89c88369afdc90b82a14da8
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/notify/ mm//

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   fs/notify/fanotify/fanotify_user.c: In function 'fanotify_event_len':
>> fs/notify/fanotify/fanotify_user.c:154:24: warning: variable 'info' set but not used [-Wunused-but-set-variable]
     154 |  struct fanotify_info *info;
         |                        ^~~~


vim +/info +154 fs/notify/fanotify/fanotify_user.c

7326e382c21e9c Amir Goldstein          2021-11-29  149  
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25  150  static size_t fanotify_event_len(unsigned int info_mode,
929943b38daf81 Amir Goldstein          2020-07-16  151  				 struct fanotify_event *event)
5e469c830fdb5a Amir Goldstein          2019-01-10  152  {
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25  153  	size_t event_len = FAN_EVENT_METADATA_LEN;
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25 @154  	struct fanotify_info *info;
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25  155  	int fh_len;
929943b38daf81 Amir Goldstein          2020-07-16  156  	int dot_len = 0;
f454fa610a69b9 Amir Goldstein          2020-07-16  157  
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25  158  	if (!info_mode)
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25  159  		return event_len;
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25  160  
130a3c742107ac Gabriel Krisman Bertazi 2021-10-25  161  	if (fanotify_is_error_event(event->mask))
130a3c742107ac Gabriel Krisman Bertazi 2021-10-25  162  		event_len += FANOTIFY_ERROR_INFO_LEN;
130a3c742107ac Gabriel Krisman Bertazi 2021-10-25  163  
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25  164  	info = fanotify_event_info(event);
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25  165  
7326e382c21e9c Amir Goldstein          2021-11-29  166  	if (fanotify_event_has_any_dir_fh(event)) {
7326e382c21e9c Amir Goldstein          2021-11-29  167  		event_len += fanotify_dir_name_info_len(event);
d3424c9bac893b Matthew Bobrowski       2021-08-08  168  	} else if ((info_mode & FAN_REPORT_NAME) &&
d3424c9bac893b Matthew Bobrowski       2021-08-08  169  		   (event->mask & FAN_ONDIR)) {
929943b38daf81 Amir Goldstein          2020-07-16  170  		/*
929943b38daf81 Amir Goldstein          2020-07-16  171  		 * With group flag FAN_REPORT_NAME, if name was not recorded in
929943b38daf81 Amir Goldstein          2020-07-16  172  		 * event on a directory, we will report the name ".".
929943b38daf81 Amir Goldstein          2020-07-16  173  		 */
929943b38daf81 Amir Goldstein          2020-07-16  174  		dot_len = 1;
929943b38daf81 Amir Goldstein          2020-07-16  175  	}
afc894c784c84c Jan Kara                2020-03-24  176  
af579beb666aef Matthew Bobrowski       2021-08-08  177  	if (info_mode & FAN_REPORT_PIDFD)
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25  178  		event_len += FANOTIFY_PIDFD_INFO_HDR_LEN;
af579beb666aef Matthew Bobrowski       2021-08-08  179  
4bd5a5c8e6e5cd Gabriel Krisman Bertazi 2021-10-25  180  	if (fanotify_event_has_object_fh(event)) {
4bd5a5c8e6e5cd Gabriel Krisman Bertazi 2021-10-25  181  		fh_len = fanotify_event_object_fh_len(event);
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25  182  		event_len += fanotify_fid_info_len(fh_len, dot_len);
4bd5a5c8e6e5cd Gabriel Krisman Bertazi 2021-10-25  183  	}
5e469c830fdb5a Amir Goldstein          2019-01-10  184  
b9928e80dda84b Gabriel Krisman Bertazi 2021-10-25  185  	return event_len;
5e469c830fdb5a Amir Goldstein          2019-01-10  186  }
5e469c830fdb5a Amir Goldstein          2019-01-10  187  

:::::: The code at line 154 was first introduced by commit
:::::: b9928e80dda84b349ba8de01780b9bef2fc36ffa fanotify: Fold event size calculation to its own function

:::::: TO: Gabriel Krisman Bertazi <krisman@...labora.com>
:::::: CC: Jan Kara <jack@...e.cz>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org