linux-kernel - RE: [PATCH v6 19/21] kvm: selftests: Add support for KVM_CAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6607eb58f61b44a5a9403cf275be4265@intel.com>
Date:   Tue, 18 Jan 2022 02:06:45 +0000
From:   "Wang, Wei W" <wei.w.wang@...el.com>
To:     Janis Schoetterl-Glausch <scgl@...ux.ibm.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>
CC:     "Zeng, Guang" <guang.zeng@...el.com>,
        "Liu, Jing2" <jing2.liu@...el.com>,
        "Tian, Kevin" <kevin.tian@...el.com>,
        "seanjc@...gle.com" <seanjc@...gle.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "Zhong, Yang" <yang.zhong@...el.com>
Subject: RE: [PATCH v6 19/21] kvm: selftests: Add support for KVM_CAP_XSAVE2

On Tuesday, January 18, 2022 12:51 AM, Janis Schoetterl-Glausch wrote:
> > +	/*
> > +	 * Permission needs to be requested before KVM_SET_CPUID2.
> > +	 */
> > +	vm_xsave_req_perm();
> > +
> 
> Since
> 
> 79e06c4c4950 (Merge tag 'for-linus' of
> git://git.kernel.org/pub/scm/virt/kvm/kvm)
> 
> on s390x I'm getting:
> 
> /usr/bin/ld: tools/testing/selftests/kvm/libkvm.a(kvm_util.o): in function
> `vm_create_with_vcpus':
> tools/testing/selftests/kvm/lib/kvm_util.c:399: undefined reference to
> `vm_xsave_req_perm'
> collect2: error: ld returned 1 exit status
> make: *** [../lib.mk:146: tools/testing/selftests/kvm/s390x/memop] Error 1
> 
> Looks like it only exists for x86.
> v2 had a comment about unconditional enablement:
> https://lore.kernel.org/kvm/e20f590b-b9d9-237d-3b9c-77dd82a24b40@redh
> at.com/
> 
> Thanks for having a look.
> 


OK, we made it conditionally enabled at runtime, but this one requires conditionally compiled. I'll get you a patch to test soon.

Thanks,
Wei