linux-kernel - Re: [PATCH] drm/virtio: Ensure that objs is not NULL in virtio_gpu_array_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220118065624.uw76mxi2ij3ho4r4@sirius.home.kraxel.org>
Date:   Tue, 18 Jan 2022 07:56:24 +0100
From:   Gerd Hoffmann <kraxel@...hat.com>
To:     Roberto Sassu <roberto.sassu@...wei.com>
Cc:     airlied@...ux.ie, daniel@...ll.ch, dri-devel@...ts.freedesktop.org,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        syzbot+e9072e90624a31dfa85f@...kaller.appspotmail.com
Subject: Re: [PATCH] drm/virtio: Ensure that objs is not NULL in
 virtio_gpu_array_put_free()

On Mon, Dec 13, 2021 at 07:31:22PM +0100, Roberto Sassu wrote:
> If virtio_gpu_object_shmem_init() fails (e.g. due to fault injection, as it
> happened in the bug report by syzbot), virtio_gpu_array_put_free() could be
> called with objs equal to NULL.
> 
> Ensure that objs is not NULL in virtio_gpu_array_put_free(), or otherwise
> return from the function.
> 
> Cc: stable@...r.kernel.org # 5.13.x
> Signed-off-by: Roberto Sassu <roberto.sassu@...wei.com>
> Reported-by: syzbot+e9072e90624a31dfa85f@...kaller.appspotmail.com
> Fixes: 377f8331d0565 ("drm/virtio: fix possible leak/unlock virtio_gpu_object_array")

Pushed to drm-misc-next.

thanks,
  Gerd