linux-kernel - Re: [PATCH] drivers/scsi/csiostor: do not sleep with a spin lock held

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f5428b2-4d36-29a1-ef1a-d544cec25bd7@opensource.wdc.com>
Date:   Wed, 19 Jan 2022 18:05:58 +0900
From:   Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To:     cgel.zte@...il.com
Cc:     chi.minghao@....com.cn, jejb@...ux.ibm.com,
        linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
        martin.petersen@...cle.com, zealci@....com.cn
Subject: Re: [PATCH] drivers/scsi/csiostor: do not sleep with a spin lock held

On 1/19/22 17:57, cgel.zte@...il.com wrote:
> 
> The might_sleep_if(gfp_mask & __GFP_DIRECT_RECLAIM) in the 
> mempool_alloc function uses __GFP_DIRECT_RECLAIM.

But the call to mempool_alloc() specifies GFP_ATOMIC, which does not
have __GFP_DIRECT_RECLAIM, so "gfp_mask & __GFP_DIRECT_RECLAIM" should
be false, and the might_sleep_if() not triggering. How can you see the
might sleep warning ?

-- 
Damien Le Moal
Western Digital Research