linux-kernel - Re: [RESEND][PATCH] checkpatch: make sure fix-up patches have Fixes tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO=4fJPTiNKvru=+qAasMZYUmsGQe+OBH4A2Dd1v-NFdQ8f-Qw@mail.gmail.com>
Date:   Wed, 19 Jan 2022 09:48:32 +0000
From:   Andy Whitcroft <apw@...onical.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Sergey Senozhatsky <senozhatsky@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Ricardo Ribalda <ribalda@...omium.org>,
        Tomasz Figa <tfiga@...omium.org>, linux-kernel@...r.kernel.org
Subject: Re: [RESEND][PATCH] checkpatch: make sure fix-up patches have Fixes tag

On Wed, Jan 19, 2022 at 9:42 AM Joe Perches <joe@...ches.com> wrote:
>
> On Wed, 2022-01-19 at 16:46 +0900, Sergey Senozhatsky wrote:
> > If a patch contains "commit hash (commit name)", in other words
> > if the patch fixes some particular commit, then require "Fixes:"
> > tag.
>
> I do not like this patch as many commits merely reference a
> previous patch and do not actually fix anything.

Agree.  It would need to be a tighter form of language to be safe to
automatically suggest a Fixes tag.  The point of a Fixes tag is to be
a semantically safe indicator of this relationship not relying on the
vagaries of English for that connection.

You might be ok with something which is a tighter match on like
"fixes <hash> (<name>)" and only suggesting a Fixes.

-apw