linux-kernel - Re: drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Yefn/J0D33c9bDO+@kroah.com>
Date:   Wed, 19 Jan 2022 11:29:16 +0100
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     David Binderman <dcb314@...mail.com>
Cc:     "mchehab@...nel.org" <mchehab@...nel.org>,
        "sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-staging@...ts.linux.dev" <linux-staging@...ts.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re:
 drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c:275: dangling
 pointer ?

On Tue, Jan 18, 2022 at 09:53:48AM +0000, David Binderman wrote:
> Hello there,
> 
> Recent gcc development versions say:
> 
> drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c:275:33: warning: storing the address of local variable ‘h’ in ‘*handle’ [-Wdangling-pointer=]
> 
> Source code is
> 
>       *handle = &h;
> 
> but h is a stack local variable, so exporting its address doesn't make any sense.

Great, can you send a patch to fix this up?

thanks,

greg k-h