linux-kernel - RE: [PATCH v2 14/16] arm64: dts: fsd: Add initial device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Jan 2022 20:37:40 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...onical.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Cc:     <soc@...nel.org>, <linux-clk@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <olof@...om.net>, <arnd@...db.de>,
        <linus.walleij@...aro.org>, <catalin.marinas@....com>,
        <robh+dt@...nel.org>, <s.nawrocki@...sung.com>,
        <linux-samsung-soc@...r.kernel.org>, <pankaj.dubey@...sung.com>,
        <linux-fsd@...la.com>, "'Arjun K V'" <arjun.kv@...sung.com>,
        "'Aswani Reddy'" <aswani.reddy@...sung.com>,
        "'Ajay Kumar'" <ajaykumar.rs@...sung.com>,
        "'Sriranjani P'" <sriranjani.p@...sung.com>,
        "'Chandrasekar R'" <rcsekar@...sung.com>,
        "'Shashank Prashar'" <s.prashar@...sung.com>
Subject: RE: [PATCH v2 14/16] arm64: dts: fsd: Add initial device tree
 support



>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@...onical.com]
>Sent: Wednesday, January 19, 2022 12:15 AM
>To: Alim Akhtar <alim.akhtar@...sung.com>; linux-arm-
>kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
>Cc: soc@...nel.org; linux-clk@...r.kernel.org; devicetree@...r.kernel.org;
>olof@...om.net; arnd@...db.de; linus.walleij@...aro.org;
>catalin.marinas@....com; robh+dt@...nel.org; s.nawrocki@...sung.com;
>linux-samsung-soc@...r.kernel.org; pankaj.dubey@...sung.com; linux-
>fsd@...la.com; Arjun K V <arjun.kv@...sung.com>; Aswani Reddy
><aswani.reddy@...sung.com>; Ajay Kumar <ajaykumar.rs@...sung.com>;
>Sriranjani P <sriranjani.p@...sung.com>; Chandrasekar R
><rcsekar@...sung.com>; Shashank Prashar <s.prashar@...sung.com>
>Subject: Re: [PATCH v2 14/16] arm64: dts: fsd: Add initial device tree support
>
>On 18/01/2022 15:48, Alim Akhtar wrote:
>> Add initial device tree support for "Full Self-Driving" (FSD) SoC This
>> SoC contain three clusters of four cortex-a72 CPUs and various
>> peripheral IPs.
>>
>> Cc: linux-fsd@...la.com
>> Signed-off-by: Arjun K V <arjun.kv@...sung.com>
>> Signed-off-by: Aswani Reddy <aswani.reddy@...sung.com>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs@...sung.com>
>> Signed-off-by: Sriranjani P <sriranjani.p@...sung.com>
>> Signed-off-by: Chandrasekar R <rcsekar@...sung.com>
>> Signed-off-by: Shashank Prashar <s.prashar@...sung.com>
>> Signed-off-by: Alim Akhtar <alim.akhtar@...sung.com>
>> ---
>>  MAINTAINERS                           |   8 +
>>  arch/arm64/Kconfig.platforms          |   7 +
>>  arch/arm64/boot/dts/Makefile          |   1 +
>>  arch/arm64/boot/dts/tesla/Makefile    |   3 +
>>  arch/arm64/boot/dts/tesla/fsd-evb.dts |  39 ++
>>  arch/arm64/boot/dts/tesla/fsd.dtsi    | 651
>++++++++++++++++++++++++++
>>  6 files changed, 709 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/tesla/Makefile
>>  create mode 100644 arch/arm64/boot/dts/tesla/fsd-evb.dts
>>  create mode 100644 arch/arm64/boot/dts/tesla/fsd.dtsi
>>
>
>I saw you dropped the MCT timer from DTSI. I wonder why?
>
I dropped it intentionally, as you had a comment on MCT driver changes, so will send later along with MCT driver fix.

>Not very happy with FSD naming (as discussed before), but board compatible
>looks reasonable. Code looks good to me:
>Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
>
Thanks Krzysztof for all the reviews.

>Similarly to previous vendor-prefix patch, please let me know if it's expected
>me to take it. I assume no. :)
>
I am expecting this will go via your tree, but I am ok either ways. May be you and arm-soc maintainers (Arnd/Olof) can take the call here.

>Best regards,
>Krzysztof