| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <de35edd9-b85d-0ed7-98b6-7a41134c3ece@foss.st.com>
Date: Wed, 19 Jan 2022 16:21:32 +0100
From: Arnaud POULIQUEN <arnaud.pouliquen@...s.st.com>
To: Rob Herring <robh@...nel.org>, <devicetree@...r.kernel.org>
CC: <linux-kernel@...r.kernel.org>,
Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
Herbert Xu <herbert@...dor.apana.org.au>,
"David S. Miller" <davem@...emloft.net>,
Chun-Kuang Hu <chunkuang.hu@...nel.org>,
Philipp Zabel <p.zabel@...gutronix.de>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
Vinod Koul <vkoul@...nel.org>,
Georgi Djakov <djakov@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Marc Zyngier <maz@...nel.org>, Joerg Roedel <joro@...tes.org>,
Lee Jones <lee.jones@...aro.org>,
Daniel Thompson <daniel.thompson@...aro.org>,
Jingoo Han <jingoohan1@...il.com>, Pavel Machek <pavel@....cz>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
Jakub Kicinski <kuba@...nel.org>,
Wolfgang Grandegger <wg@...ndegger.com>,
Marc Kleine-Budde <mkl@...gutronix.de>,
Andrew Lunn <andrew@...n.ch>,
Vivien Didelot <vivien.didelot@...il.com>,
Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
Kalle Valo <kvalo@...nel.org>,
Viresh Kumar <vireshk@...nel.org>,
Stephen Boyd <sboyd@...nel.org>,
Kishon Vijay Abraham I <kishon@...com>,
Linus Walleij <linus.walleij@...aro.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Kevin Hilman <khilman@...nel.org>,
Ulf Hansson <ulf.hansson@...aro.org>,
Sebastian Reichel <sre@...nel.org>,
Mark Brown <broonie@...nel.org>,
Mathieu Poirier <mathieu.poirier@...aro.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Zhang Rui <rui.zhang@...el.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Thierry Reding <thierry.reding@...il.com>,
Jonathan Hunter <jonathanh@...dia.com>,
Sudeep Holla <sudeep.holla@....com>,
Geert Uytterhoeven <geert+renesas@...der.be>,
<linux-ide@...r.kernel.org>, <linux-crypto@...r.kernel.org>,
<dri-devel@...ts.freedesktop.org>, <dmaengine@...r.kernel.org>,
<linux-pm@...r.kernel.org>, <iommu@...ts.linux-foundation.org>,
<linux-leds@...r.kernel.org>, <linux-media@...r.kernel.org>,
<netdev@...r.kernel.org>, <linux-can@...r.kernel.org>,
<linux-wireless@...r.kernel.org>, <linux-phy@...ts.infradead.org>,
<linux-gpio@...r.kernel.org>, <linux-riscv@...ts.infradead.org>,
<linux-remoteproc@...r.kernel.org>, <alsa-devel@...a-project.org>,
<linux-usb@...r.kernel.org>
Subject: Re: [PATCH] dt-bindings: Improve phandle-array schemas
Hello Rob,
On 1/19/22 2:50 AM, Rob Herring wrote:
> The 'phandle-array' type is a bit ambiguous. It can be either just an
> array of phandles or an array of phandles plus args. Many schemas for
> phandle-array properties aren't clear in the schema which case applies
> though the description usually describes it.
>
> The array of phandles case boils down to needing:
>
> items:
> maxItems: 1
>
> The phandle plus args cases should typically take this form:
>
> items:
> - items:
> - description: A phandle
> - description: 1st arg cell
> - description: 2nd arg cell
>
> With this change, some examples need updating so that the bracketing of
> property values matches the schema.
>
> Cc: Damien Le Moal <damien.lemoal@...nsource.wdc.com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Chun-Kuang Hu <chunkuang.hu@...nel.org>
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Cc: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
> Cc: Vinod Koul <vkoul@...nel.org>
> Cc: Georgi Djakov <djakov@...nel.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Marc Zyngier <maz@...nel.org>
> Cc: Joerg Roedel <joro@...tes.org>
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Daniel Thompson <daniel.thompson@...aro.org>
> Cc: Jingoo Han <jingoohan1@...il.com>
> Cc: Pavel Machek <pavel@....cz>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Wolfgang Grandegger <wg@...ndegger.com>
> Cc: Marc Kleine-Budde <mkl@...gutronix.de>
> Cc: Andrew Lunn <andrew@...n.ch>
> Cc: Vivien Didelot <vivien.didelot@...il.com>
> Cc: Florian Fainelli <f.fainelli@...il.com>
> Cc: Vladimir Oltean <olteanv@...il.com>
> Cc: Kalle Valo <kvalo@...nel.org>
> Cc: Viresh Kumar <vireshk@...nel.org>
> Cc: Stephen Boyd <sboyd@...nel.org>
> Cc: Kishon Vijay Abraham I <kishon@...com>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Cc: Kevin Hilman <khilman@...nel.org>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Cc: Sebastian Reichel <sre@...nel.org>
> Cc: Mark Brown <broonie@...nel.org>
> Cc: Mathieu Poirier <mathieu.poirier@...aro.org>
> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> Cc: Zhang Rui <rui.zhang@...el.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: Jonathan Hunter <jonathanh@...dia.com>
> Cc: Sudeep Holla <sudeep.holla@....com>
> Cc: Geert Uytterhoeven <geert+renesas@...der.be>
> Cc: linux-ide@...r.kernel.org
> Cc: linux-crypto@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org
> Cc: dmaengine@...r.kernel.org
> Cc: linux-pm@...r.kernel.org
> Cc: iommu@...ts.linux-foundation.org
> Cc: linux-leds@...r.kernel.org
> Cc: linux-media@...r.kernel.org
> Cc: netdev@...r.kernel.org
> Cc: linux-can@...r.kernel.org
> Cc: linux-wireless@...r.kernel.org
> Cc: linux-phy@...ts.infradead.org
> Cc: linux-gpio@...r.kernel.org
> Cc: linux-riscv@...ts.infradead.org
> Cc: linux-remoteproc@...r.kernel.org
> Cc: alsa-devel@...a-project.org
> Cc: linux-usb@...r.kernel.org
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
[...]
> .../bindings/remoteproc/st,stm32-rproc.yaml | 33 ++++++--
[...]
> diff --git a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
> index b587c97c282b..be3d9b0e876b 100644
> --- a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.yaml
> @@ -29,17 +29,22 @@ properties:
>
> st,syscfg-holdboot:
> description: remote processor reset hold boot
> - - Phandle of syscon block.
> - - The offset of the hold boot setting register.
> - - The field mask of the hold boot.
> $ref: "/schemas/types.yaml#/definitions/phandle-array"
> - maxItems: 1
> + items:
> + - items:
> + - description: Phandle of syscon block
> + - description: The offset of the hold boot setting register
> + - description: The field mask of the hold boot
>
> st,syscfg-tz:
> description:
> Reference to the system configuration which holds the RCC trust zone mode
> $ref: "/schemas/types.yaml#/definitions/phandle-array"
> - maxItems: 1
> + items:
> + - items:
> + - description: Phandle of syscon block
> + - description: FIXME
> + - description: FIXME
- description: The offset of the trust zone setting register
- description: The field mask of the trust zone state
>
> interrupts:
> description: Should contain the WWDG1 watchdog reset interrupt
> @@ -93,20 +98,32 @@ properties:
> $ref: "/schemas/types.yaml#/definitions/phandle-array"
> description: |
> Reference to the system configuration which holds the remote
> - maxItems: 1
> + items:
> + - items:
> + - description: Phandle of syscon block
> + - description: FIXME
> + - description: FIXME
- description: The offset of the power setting register
- description: The field mask of the PDDS selection
>
> st,syscfg-m4-state:
> $ref: "/schemas/types.yaml#/definitions/phandle-array"
> description: |
> Reference to the tamp register which exposes the Cortex-M4 state.
> - maxItems: 1
> + items:
> + - items:
> + - description: Phandle of syscon block with the tamp register
> + - description: FIXME
> + - description: FIXME
- description: The offset of the tamp register
- description: The field mask of the Cortex-M4 state
>
> st,syscfg-rsc-tbl:
> $ref: "/schemas/types.yaml#/definitions/phandle-array"
> description: |
> Reference to the tamp register which references the Cortex-M4
> resource table address.
> - maxItems: 1
> + items:
> + - items:
> + - description: Phandle of syscon block with the tamp register
> + - description: FIXME
> + - description: FIXME
- description: The offset of the tamp register
- description: The field mask of the Cortex-M4 resource table address
Please tell me if you prefer that I fix this in a dedicated patch.
Thanks,
Arnaud
Powered by blists - more mailing lists