linux-kernel - Re: [PATCH v3] spi: stm32-qspi: Update spi registering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220119152950.GA4445@wunner.de>
Date:   Wed, 19 Jan 2022 16:29:50 +0100
From:   Lukas Wunner <lukas@...ner.de>
To:     patrice.chotard@...s.st.com
Cc:     Mark Brown <broonie@...nel.org>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        linux-spi@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        christophe.kerello@...s.st.com
Subject: Re: [PATCH v3] spi: stm32-qspi: Update spi registering

On Mon, Jan 17, 2022 at 01:17:44PM +0100, patrice.chotard@...s.st.com wrote:
> Some device driver need to communicate to qspi device during the remove
> process, qspi controller must be functional when spi_unregister_master()
> is called.
> 
> To ensure this, replace devm_spi_register_master() by spi_register_master()
> and spi_unregister_master() is called directly in .remove callback before
> stopping the qspi controller.
> 
> This issue was put in evidence using kernel v5.11 and later
> with a spi-nor which supports the software reset feature introduced
> by commit d73ee7534cc5 ("mtd: spi-nor: core: perform a Soft Reset on
> shutdown")
> 
> Fixes: c530cd1d9d5e ("spi: spi-mem: add stm32 qspi controller")
> 
> Signed-off-by: Patrice Chotard <patrice.chotard@...s.st.com>
> Cc: <stable@...r.kernel.org> # 5.8.x

Reviewed-by: Lukas Wunner <lukas@...ner.de>

Thanks!

Lukas